[compute_instance] - Allow updating of network and subnetwork properties

[ScottSuarez]

Allow updating of network and subnetwork properties on resource_compute_instance.
Some issues of 7118 are fixed. Still need to add support for updating network_ip during subnetwork change. This would require utilizing a customized diff.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added support for updating `network_interface.[d].network` and `network_interface.[d].subnetwork` properties on `google_compute_instance`.

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148164"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 280 insertions(+), 42 deletions(-))
Terraform Beta: Diff ( 2 files changed, 280 insertions(+), 42 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148166"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 280 insertions(+), 42 deletions(-))
Terraform Beta: Diff ( 2 files changed, 280 insertions(+), 42 deletions(-))

[danawillow]

Here's some initial comments from a first pass. Also, watch out for the release note- we usually put just the product in the beginning (so "compute" in this case), and then the name of the resource somewhere in the body of the note.

[ScottSuarez]

Responding to comments

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148326"

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148326"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 271 insertions(+), 42 deletions(-))
Terraform Beta: Diff ( 2 files changed, 271 insertions(+), 42 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 271 insertions(+), 42 deletions(-))
Terraform Beta: Diff ( 2 files changed, 271 insertions(+), 42 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148326"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 269 insertions(+), 42 deletions(-))
Terraform Beta: Diff ( 2 files changed, 269 insertions(+), 42 deletions(-))

[danawillow]

A few more small comments, nothing too major. I'm curious about the answer to @drebes's question as well.

This change is also making me think that we should prioritize the new instances.update method a bit higher. The update function in this resource is suuuuper long, and I'm nervous there are combinations of updates that we're not catching.

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148423"

[ScottSuarez]

Responding to comments.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 254 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 2 files changed, 254 insertions(+), 32 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148424"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 258 insertions(+), 33 deletions(-))
Terraform Beta: Diff ( 2 files changed, 258 insertions(+), 33 deletions(-))

[rileykarson]

Removing myself as a reviewer since Dana reviewed this- feel free to add me back if you'd like me to make a pass, though.

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148439"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 258 insertions(+), 33 deletions(-))
Terraform Beta: Diff ( 2 files changed, 258 insertions(+), 33 deletions(-))

[c2thorn]

Definitely didn't expect this to be so complex when you started out. My main concern is about adding some documentation about how we are approaching update behavior. The rest are just soft suggestions

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148526"

[danawillow]

Once Cameron's suggestions are resolved, I'm satisfied. I went ahead and retried the VCR tests since TeamCity ran out of memory on the last run- I assume you've run the new test and I don't expect this to affect existing tests, so if it has problems again I don't think it's worth blocking on.

[danawillow]

Oh also I went ahead and edited the changelog note to match the guidelines- take a look at the edits I made so you can better understand what I mean by that :)

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148526"

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148526"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 259 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 2 files changed, 259 insertions(+), 34 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 259 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 2 files changed, 259 insertions(+), 34 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148526"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 261 insertions(+), 35 deletions(-))
Terraform Beta: Diff ( 3 files changed, 261 insertions(+), 35 deletions(-))