-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow updating dataproc cluster autoscaling_policy #3976
allow updating dataproc cluster autoscaling_policy #3976
Conversation
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=145876" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeRegionSslCertificate|TestAccComputeSnapshot_encryptionCMEK|TestAccDataCatalogTag_dataCatalogEntryGroupTagExample|TestAccDataCatalogTag_dataCatalogEntryTagBasicExample|TestAccDataCatalogTag_update|TestAccDataprocCluster_withAutoscalingPolicy You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=145881" |
}, | ||
{ | ||
Config: testAccDataprocCluster_removeAutoscalingPolicy(rnd), | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we don't need a check here because we are just making sure a diff doesn't exist after applying?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we would have an import step, but we don't actually support import yet for dataproc clusters. I suppose it probably makes sense to check the object though to make sure removing the autoscaling policy actually removes it (vs just removing it from state). Will do shortly.
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=146405" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeSnapshot_encryptionCMEK|TestAccDataCatalogTag_dataCatalogEntryGroupTagExample|TestAccDataCatalogTag_dataCatalogEntryTagBasicExample|TestAccDataCatalogTag_update|TestAccDataprocCluster_withAutoscalingPolicy You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=146407" |
Test passes, merging. |
Fixes hashicorp/terraform-provider-google#7096
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)