Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow updating dataproc cluster autoscaling_policy #3976

Merged

Conversation

danawillow
Copy link
Contributor

@danawillow danawillow commented Sep 11, 2020

Fixes hashicorp/terraform-provider-google#7096

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dataproc: fixed issues where updating `google_dataproc_cluster.cluster_config.autoscaling_policy` would do nothing, and where there was no way to remove a policy.

@google-cla google-cla bot added the cla: yes label Sep 11, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 142 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 4 files changed, 142 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=145876"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeRegionSslCertificate|TestAccComputeSnapshot_encryptionCMEK|TestAccDataCatalogTag_dataCatalogEntryGroupTagExample|TestAccDataCatalogTag_dataCatalogEntryTagBasicExample|TestAccDataCatalogTag_update|TestAccDataprocCluster_withAutoscalingPolicy You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=145881"

@danawillow danawillow requested a review from c2thorn September 11, 2020 23:36
},
{
Config: testAccDataprocCluster_removeAutoscalingPolicy(rnd),
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we don't need a check here because we are just making sure a diff doesn't exist after applying?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would have an import step, but we don't actually support import yet for dataproc clusters. I suppose it probably makes sense to check the object though to make sure removing the autoscaling policy actually removes it (vs just removing it from state). Will do shortly.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 163 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 4 files changed, 163 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=146405"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeSnapshot_encryptionCMEK|TestAccDataCatalogTag_dataCatalogEntryGroupTagExample|TestAccDataCatalogTag_dataCatalogEntryTagBasicExample|TestAccDataCatalogTag_update|TestAccDataprocCluster_withAutoscalingPolicy You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=146407"

@danawillow
Copy link
Contributor Author

Test passes, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Dataproc autoscaling_policy
3 participants