Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resource_container_cluster] - Add self-link property #3942

Merged

Conversation

ScottSuarez
Copy link
Contributor

@ScottSuarez ScottSuarez commented Sep 2, 2020

Add self link property to resource_container_cluster.

Resolves 7120

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: Added `self_link` to google_container_cluster

@google-cla google-cla bot added the cla: yes label Sep 2, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@megan07, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 75 insertions(+), 60 deletions(-))
Terraform Beta: Diff ( 1 file changed, 101 insertions(+), 89 deletions(-))

Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ScottSuarez! Were you able to build this locally? If you need any help with that, feel free to reach out!

Type: schema.TypeString,
Computed: true,
Description: `Server-defined URL for the resource.`,
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want a comma after this here.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 13 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 2 files changed, 13 insertions(+), 6 deletions(-))

Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for cleaning up the whitespace. Do you think we should add a test in for this?

@ScottSuarez
Copy link
Contributor Author

Looks good! Thanks for cleaning up the whitespace. Do you think we should add a test in for this?

It certainly couldn't hurt! I added the property validation to an existing basic test and ran it locally.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 15 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 15 insertions(+), 7 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add self_link to google_container_cluster
3 participants