Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google service account docs to display correct public key type #3787

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Update Google service account docs to display correct public key type #3787

merged 1 commit into from
Jul 28, 2020

Conversation

onlydole
Copy link
Contributor

@onlydole onlydole commented Jul 27, 2020

Release Note Template for Downstream PRs (will be copied)

@google-cla
Copy link

google-cla bot commented Jul 27, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jul 27, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

@modular-magician modular-magician requested a review from c2thorn July 27, 2020 21:45
@onlydole
Copy link
Contributor Author

@googlebot I signed it!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 26 insertions(+), 29 deletions(-))
Terraform Beta: Diff ( 2 files changed, 26 insertions(+), 29 deletions(-))

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! TYPE_X509_PEM_FILE certainly seems correct according to https://cloud.google.com/iam/docs/reference/rest/v1/projects.serviceAccounts.keys/get . One minor complaint about the html formatting, but otherwise looks good.

@onlydole
Copy link
Contributor Author

Thank you, @c2thorn! I have updated with your feedback, please let me know if you need anything else for this to be merged in/approved and I'll be happy to update accordingly.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 14 insertions(+), 17 deletions(-))
Terraform Beta: Diff ( 2 files changed, 14 insertions(+), 17 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 7 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 2 files changed, 7 insertions(+), 10 deletions(-))

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great, thank you so much @onlydole !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants