Add ability to set global network endpoint group as backend #3764

slevenick · 2020-07-21T21:37:20Z

Fixes: hashicorp/terraform-provider-google#6155

Add ability to set global network endpoint group as backend for backend service. Make health_checks optional if NEG is used. Virtual field added to enable this

Release Note Template for Downstream PRs (will be copied)

`compute`: Added support to `google_compute_backend_service` for setting a network endpoint group as `backend.group`

modular-magician · 2020-07-21T21:44:11Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 137 insertions(+), 24 deletions(-))
Terraform Beta: Diff ( 3 files changed, 137 insertions(+), 24 deletions(-))
Ansible: Diff ( 1 file changed, 3 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 15 insertions(+), 1 deletion(-))

modular-magician · 2020-07-21T21:44:21Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134590"

modular-magician · 2020-07-21T22:02:29Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_internalLoadBalancing|TestAccComputeInstanceGroup_rename|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccContainerCluster_backend|TestAccFolderIamAuditConfig_multiple|TestAccServiceAccountIamMember_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134593"

modular-magician · 2020-07-21T22:21:47Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 121 insertions(+), 38 deletions(-))
Terraform Beta: Diff ( 5 files changed, 121 insertions(+), 38 deletions(-))
Ansible: Diff ( 1 file changed, 3 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician · 2020-07-21T22:21:54Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134596"

modular-magician · 2020-07-21T22:41:04Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 120 insertions(+), 38 deletions(-))
Terraform Beta: Diff ( 5 files changed, 120 insertions(+), 38 deletions(-))
Ansible: Diff ( 1 file changed, 3 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician · 2020-07-21T22:41:11Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134597"

modular-magician · 2020-07-21T22:56:57Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeNetworkEndpointGroup|TestAccDataSourceGoogleNetwork|TestAccDataSourceComputeRouter|TestAccDataSourceGoogleSubnetwork|TestAccComputeSubnetworkIamBindingGenerated|TestAccComputeSubnetworkIamMemberGenerated|TestAccComputeSubnetworkIamPolicyGenerated|TestAccCloudFunctionsFunction_vpcConnector|TestAccComposerEnvironment_basic|TestAccComposerEnvironment_update|TestAccComposerEnvironment_private|TestAccComposerEnvironment_withNodeConfig|TestAccComposerEnvironment_withUpdateOnCreate|TestAccComposerEnvironment_withSoftwareConfig|TestAccComputeAddress_addressWithSubnetworkExample|TestAccComputeAddress_internal|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeFirewall_firewallBasicExample|TestAccComputeFirewall_update|TestAccComputeFirewall_priority|TestAccComputeFirewall_noSource|TestAccComputeFirewall_denied|TestAccComputeFirewall_disabled|TestAccComputeFirewall_serviceAccounts|TestAccComputeFirewall_egress|TestAccComputeFirewall_enableLogging|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeGlobalAddress_internal|TestAccComputeInstanceGroup_network|TestAccComputeInstanceTemplate_subnet_auto|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstance_subnet_auto|TestAccComputeInstance_subnet_custom|TestAccComputeInstance_network_ip_custom|TestAccComputeInstance_networkIPAuto|TestAccComputeInstance_multiNic|TestAccComputeInstance_secondaryAliasIpRange|TestAccComputeNetworkEndpointGroup_networkEndpointGroupExample|TestAccComputeNetwork_networkBasicExample|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccComputeNetworkPeering_basic|TestAccComputeNetworkPeering_subnetRoutes|TestAccComputeNetwork_explicitAutoSubnet|TestAccComputeNetwork_networkDeleteDefaultRoute|TestAccComputeNetwork_routingModeAndUpdate|TestAccComputeNetwork_customSubnet|TestAccComputeNetwork_default_routing_mode|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRoute_routeBasicExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRouter_routerBasicExample|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeRouterInterface_basic|TestAccComputeRouterNat_basic|TestAccComputeRouterNat_update|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouter_basic|TestAccComputeRouter_noRegion|TestAccComputeRouter_full|TestAccComputeRouter_updateAddRemoveBGP|TestAccComputeRouter_update|TestAccComputeSubnetwork_subnetworkBasicExample|TestAccComputeSubnetwork_subnetworkLoggingConfigExample|TestAccComputeSubnetworkIamPolicy|TestAccComputeSubnetwork_update|TestAccComputeSubnetwork_basic|TestAccComputeSubnetwork_secondaryIpRanges|TestAccComputeSubnetwork_flowLogs|TestAccComputeSubnetwork_flowLogsMigrate|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccContainerCluster_network|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_maxPodsPerNode|TestAccDataprocCluster_withInternalIpOnlyTrue|TestAccDNSManagedZone_dnsManagedZonePrivateExample|TestAccDNSManagedZone_dnsManagedZonePrivatePeeringExample|TestAccDNSManagedZone_privateUpdate|TestAccDNSManagedZone_privateForwardingUpdate|TestAccDNSPolicy_update|TestAccDNSPolicy_dnsPolicyBasicExample|TestAccServiceAccountIamMember_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134598"

modular-magician · 2020-07-21T23:06:56Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 120 insertions(+), 38 deletions(-))
Terraform Beta: Diff ( 5 files changed, 120 insertions(+), 38 deletions(-))
Ansible: Diff ( 1 file changed, 3 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician · 2020-07-21T23:07:03Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134599"

modular-magician · 2020-07-21T23:22:16Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeNetworkEndpointGroup|TestAccDataSourceGoogleNetwork|TestAccDataSourceComputeRouter|TestAccDataSourceGoogleSubnetwork|TestAccComputeSubnetworkIamBindingGenerated|TestAccComputeSubnetworkIamMemberGenerated|TestAccComputeSubnetworkIamPolicyGenerated|TestAccCloudFunctionsFunction_vpcConnector|TestAccComposerEnvironment_basic|TestAccComposerEnvironment_update|TestAccComposerEnvironment_private|TestAccComposerEnvironment_withNodeConfig|TestAccComposerEnvironment_withUpdateOnCreate|TestAccComposerEnvironment_withSoftwareConfig|TestAccComputeAddress_addressWithSubnetworkExample|TestAccComputeAddress_internal|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeFirewall_firewallBasicExample|TestAccComputeFirewall_update|TestAccComputeFirewall_priority|TestAccComputeFirewall_noSource|TestAccComputeFirewall_serviceAccounts|TestAccComputeFirewall_denied|TestAccComputeFirewall_egress|TestAccComputeFirewall_disabled|TestAccComputeFirewall_enableLogging|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeGlobalAddress_internal|TestAccComputeInstanceGroup_network|TestAccComputeInstanceTemplate_subnet_auto|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstance_subnet_auto|TestAccComputeInstance_subnet_custom|TestAccComputeInstance_networkIPAuto|TestAccComputeInstance_network_ip_custom|TestAccComputeInstance_multiNic|TestAccComputeInstance_secondaryAliasIpRange|TestAccComputeNetworkEndpointGroup_networkEndpointGroupExample|TestAccComputeNetwork_networkBasicExample|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccComputeNetworkPeering_basic|TestAccComputeNetworkPeering_subnetRoutes|TestAccComputeNetwork_explicitAutoSubnet|TestAccComputeNetwork_customSubnet|TestAccComputeNetwork_networkDeleteDefaultRoute|TestAccComputeNetwork_routingModeAndUpdate|TestAccComputeNetwork_default_routing_mode|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRoute_routeBasicExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRouterPeer_basic|TestAccComputeRouter_routerBasicExample|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterNat_basic|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterInterface_basic|TestAccComputeRouterNat_update|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouter_basic|TestAccComputeRouter_update|TestAccComputeRouter_noRegion|TestAccComputeRouter_full|TestAccComputeRouter_updateAddRemoveBGP|TestAccComputeSubnetwork_subnetworkLoggingConfigExample|TestAccComputeSubnetwork_subnetworkBasicExample|TestAccComputeSubnetwork_basic|TestAccComputeSubnetworkIamPolicy|TestAccComputeSubnetwork_secondaryIpRanges|TestAccComputeSubnetwork_update|TestAccComputeSubnetwork_flowLogs|TestAccComputeSubnetwork_flowLogsMigrate|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccContainerCluster_network|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_nodeLocations|TestAccDataprocCluster_withInternalIpOnlyTrue|TestAccDNSManagedZone_dnsManagedZonePrivateExample|TestAccDNSManagedZone_dnsManagedZonePrivatePeeringExample|TestAccDNSManagedZone_privateUpdate|TestAccDNSManagedZone_privateForwardingUpdate|TestAccDNSPolicy_dnsPolicyBasicExample|TestAccDNSPolicy_update|TestAccFolderIamAuditConfig_multiple You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134600"

modular-magician · 2020-07-21T23:36:59Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 106 insertions(+), 24 deletions(-))
Terraform Beta: Diff ( 3 files changed, 106 insertions(+), 24 deletions(-))
Ansible: Diff ( 1 file changed, 3 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician · 2020-07-21T23:37:07Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134602"

modular-magician · 2020-07-21T23:53:25Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccFolderIamAuditConfig_multiple|TestAccServiceAccountIamBinding_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134605"

modular-magician · 2020-07-22T14:55:48Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 106 insertions(+), 24 deletions(-))
Terraform Beta: Diff ( 3 files changed, 106 insertions(+), 24 deletions(-))
Ansible: Diff ( 1 file changed, 3 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician · 2020-07-22T14:55:55Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134820"

modular-magician · 2020-07-22T15:05:53Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 167 insertions(+), 24 deletions(-))
Terraform Beta: Diff ( 4 files changed, 167 insertions(+), 24 deletions(-))
Ansible: Diff ( 2 files changed, 15 insertions(+), 10 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 125 insertions(+))
Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician · 2020-07-22T15:06:02Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134821"

modular-magician · 2020-07-22T15:12:42Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccServiceAccountIamBinding_withAndWithoutCondition|TestAccServiceAccountIamMember_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134822"

modular-magician · 2020-07-22T16:28:49Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 113 insertions(+), 24 deletions(-))
Terraform Beta: Diff ( 3 files changed, 113 insertions(+), 24 deletions(-))
Ansible: Diff ( 2 files changed, 15 insertions(+), 10 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 125 insertions(+))
Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician · 2020-07-22T16:28:58Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134827"

modular-magician · 2020-07-22T16:45:36Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccServiceAccountIamMember_withAndWithoutCondition|TestAccServiceAccountIamBinding_withAndWithoutCondition|TestAccMonitoringMetricDescriptor_monitoringMetricDescriptorBasicExample|TestAccMonitoringMetricDescriptor_monitoringMetricDescriptorAlertExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134828"

danawillow · 2020-07-23T21:44:50Z

templates/terraform/examples/backend_service_network_endpoint.tf.erb

+}
+
+resource "google_compute_global_network_endpoint" "proxy" {
+  global_network_endpoint_group = google_compute_global_network_endpoint_group.external_proxy.name


can this be .id? (https://github.com/terraform-providers/terraform-provider-google/wiki/Developer-Best-Practices#self-links-names-and-ids)

danawillow · 2020-07-23T21:45:24Z

templates/terraform/examples/backend_service_network_endpoint.tf.erb

+  custom_request_headers          = ["host: ${google_compute_global_network_endpoint.proxy.fqdn}"]
+
+  backend {
+    group = google_compute_global_network_endpoint_group.external_proxy.self_link


danawillow · 2020-07-23T21:48:04Z

products/compute/api.yaml

@@ -779,8 +779,6 @@ objects:
                either maxRate or maxRatePerEndpoint must be set.
            - !ruby/object:Api::Type::Double
              name: 'maxUtilization'
-              send_empty_value: true
-              default_value: 0.8


The docs here still says the default is 0.8. Also, is it possible that removing this default causes diffs (since a user's state file might say 0.8 is the value but their config says it's nothing)?

Due to an interesting behavior (bug?) in backend service, max_utilization never is used in the hash function for backend: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/templates/terraform/constants/backend_service.go.erb

So modifying this field never causes a diff. I'm worried that adding this field to the hash function would be a breaking change

Also, because this is moving to Optional+Computed it shouldn't cause a diff if their config says nothing (assuming the hash function was working correctly)

https://github.com/modular-magician/terraform-provider-google-beta/compare/auto-pr-3764-old..auto-pr-3764#diff-5634ebdaad9fa3c2126514df6c5cb870R918 doesn't show it as O+C

Ah, right it doesn't come back from the API in most cases so just optional works.

Keeping send_empty_value makes terraform send a value in every circumstance, meaning that we can't not specify this field for NEG backends. I could strip it from requests for NEG backends with a virtual field, but then it still appears in state and create plans.

For some reason I'm seeing zero values be sent even with send_empty_value: false. Not entirely sure why that is happening

danawillow · 2020-07-23T21:49:14Z

products/compute/api.yaml

@@ -779,8 +779,6 @@ objects:
                either maxRate or maxRatePerEndpoint must be set.
            - !ruby/object:Api::Type::Double
              name: 'maxUtilization'
-              send_empty_value: true


Removing this means it can no longer be updated to 0 (or set explicitly to 0, if there's a server-side default that's nonzero). is that what we want?

…nd service. Make health_checks optional

modular-magician · 2020-07-24T20:26:51Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 115 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 3 files changed, 115 insertions(+), 26 deletions(-))
Ansible: Diff ( 2 files changed, 18 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 125 insertions(+))
Inspec: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

modular-magician · 2020-07-24T20:26:58Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135456"

modular-magician · 2020-07-24T20:43:15Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccFolderIamAuditConfig_multiple|TestAccMonitoringMetricDescriptor_monitoringMetricDescriptorAlertExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135458"

google-cla bot added the cla: yes label Jul 21, 2020

slevenick force-pushed the backend-service-neg branch from 75a4573 to 0656adc Compare July 21, 2020 22:59

slevenick requested a review from danawillow July 22, 2020 17:23

danawillow suggested changes Jul 23, 2020

View reviewed changes

slevenick added 4 commits July 23, 2020 15:19

Add ability to set global network endpoint group as backend for backe…

0882c0d

…nd service. Make health_checks optional

Remove virtual field that only provides validation

d43093e

Remove unused customize diff

325bbbc

Fix virtual fields

1b0ec2b

slevenick added 3 commits July 23, 2020 15:19

Unskip test

f7f2a42

Remove extra test

329efe7

PR feedback

608e786

slevenick force-pushed the backend-service-neg branch from b6a3a88 to 608e786 Compare July 24, 2020 20:19

slevenick mentioned this pull request Jul 24, 2020

Backend service support for internet NEG backend #3782

Merged

slevenick closed this Jul 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to set global network endpoint group as backend #3764

Add ability to set global network endpoint group as backend #3764

slevenick commented Jul 21, 2020 •

edited

Loading

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 22, 2020

modular-magician commented Jul 22, 2020

modular-magician commented Jul 22, 2020

modular-magician commented Jul 22, 2020

modular-magician commented Jul 22, 2020

modular-magician commented Jul 22, 2020

modular-magician commented Jul 22, 2020

modular-magician commented Jul 22, 2020

danawillow Jul 23, 2020

danawillow Jul 23, 2020

danawillow Jul 23, 2020

slevenick Jul 23, 2020

slevenick Jul 23, 2020

danawillow Jul 23, 2020

slevenick Jul 24, 2020

danawillow Jul 23, 2020

modular-magician commented Jul 24, 2020

modular-magician commented Jul 24, 2020

modular-magician commented Jul 24, 2020

Add ability to set global network endpoint group as backend #3764

Add ability to set global network endpoint group as backend #3764

Conversation

slevenick commented Jul 21, 2020 • edited Loading

modular-magician commented Jul 21, 2020

Diff report:

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

Diff report:

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

Diff report:

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

Diff report:

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

Diff report:

modular-magician commented Jul 21, 2020

modular-magician commented Jul 21, 2020

modular-magician commented Jul 22, 2020

Diff report:

modular-magician commented Jul 22, 2020

modular-magician commented Jul 22, 2020

Diff report:

modular-magician commented Jul 22, 2020

modular-magician commented Jul 22, 2020

modular-magician commented Jul 22, 2020

Diff report:

modular-magician commented Jul 22, 2020

modular-magician commented Jul 22, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented Jul 24, 2020

Diff report:

modular-magician commented Jul 24, 2020

modular-magician commented Jul 24, 2020

slevenick commented Jul 21, 2020 •

edited

Loading