default_snat_status attribute added

[venkykuberan]

Release Note Template for Downstream PRs (will be copied)

Cluster: added default_snat_status for `google_container_cluster` resource

reference: hashicorp/terraform-provider-google#6465

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 17 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 2 files changed, 90 insertions(+), 8 deletions(-))

[nat-henderson]

Is there a test that can be reasonably added to this?

[nat-henderson]

You may want to return disabled: true if c == nil, it helps plan make better decisions. :)

[venkykuberan]

that makes the default value as disabled: true, right ?. What if i don't want to set the attribute if its not in the config ?

[venkykuberan]

Added tests for this attribute.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 20 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 97 insertions(+), 9 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134419"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 20 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 97 insertions(+), 9 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134554"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccServiceAccountIamBinding_withAndWithoutCondition|TestAccServiceAccountIamMember_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134556"

[nat-henderson]

Awesome, thanks!

[danawillow]

I think this PR is causing VCR test failures. @venkykuberan , can you double check? The error is:

------- Stdout: -------
=== RUN   TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock
=== PAUSE TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock
=== CONT  TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock
TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock: testing.go:667: Step 0, expected error:
config is invalid: Unsupported block type: Blocks of type "default_snat_status" are not expected here.
To match:
master_ipv4_cidr_block must be set if enable_private_nodes == true
--- FAIL: TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock (0.33s)
FAIL

and since this is a VCR test failure, it's happening in the GA provider.

[nat-henderson]

Ah, shoot, I looked here: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstreamVcr/134556? to make sure it was passing! :(