-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional documentation about how to easily get started with credentials in the provider. #3740
Additional documentation about how to easily get started with credentials in the provider. #3740
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 18 insertions(+), 4 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=132856" |
if c, err := googleoauth.DefaultTokenSource(context.Background(), clientScopes...); err == nil { | ||
return c, err | ||
} else { | ||
return c, fmt.Errorf("Attempted to load application default credentials since neither `credentials` nor `access_token` was set in the provider block. No credentials loaded. Consider running 'gcloud auth application-default login. Original error: %w", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return c, fmt.Errorf("Attempted to load application default credentials since neither `credentials` nor `access_token` was set in the provider block. No credentials loaded. Consider running 'gcloud auth application-default login. Original error: %w", err) | |
return c, fmt.Errorf("Attempted to load application default credentials since neither `credentials` nor `access_token` was set in the provider block. No credentials loaded. Consider running 'gcloud auth application-default login'. Original error: %w", err) |
[manage key files using the Cloud Console]. | ||
[manage key files using the Cloud Console]. If not provided, the | ||
application default credentials will be used. You can configure | ||
use Application Default Credentials on your personal machine by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use Application Default Credentials on your personal machine by | |
Application Default Credentials on your personal machine by |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigQueryTable_HivePartitioningCustomSchema|TestAccEndpointsService_basic|TestAccServiceAccountIamMember_withAndWithoutCondition|TestAccServiceAccountIamBinding_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=132859" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 26 insertions(+), 4 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=132861" |
FYI I just merged in a change with a conflict to config.go.erb, shouldn't be too bad to resolve. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 22 insertions(+), 4 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134003" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccEndpointsService_basic|TestAccServiceAccountIamMember_withAndWithoutCondition|TestAccServiceAccountIamBinding_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134043" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks Nathan!
fixes hashicorp/terraform-provider-google#6780
Release Note Template for Downstream PRs (will be copied)