Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source for oidc tokens #3739

Merged
merged 12 commits into from
Jul 14, 2020

Conversation

danawillow
Copy link
Contributor

Upstreams hashicorp/terraform-provider-google#5670
Fixes hashicorp/terraform-provider-google#5669

Release Note Template for Downstream PRs (will be copied)

`google_service_account_id_token`

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 373 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 7 files changed, 373 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 1 file changed, 30 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=132427"

@danawillow danawillow requested a review from c2thorn July 13, 2020 21:25
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 373 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 7 files changed, 373 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 1 file changed, 30 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=133091"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 373 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 7 files changed, 373 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 1 file changed, 30 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=133091"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for openid connect token datasource
5 participants