Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add data source for google_sql_database_instance #3738

Merged
merged 5 commits into from
Jul 15, 2020
Merged

add data source for google_sql_database_instance #3738

merged 5 commits into from
Jul 15, 2020

Conversation

edwardmedia
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#2841

Release Note Template for Downstream PRs (will be copied)

Add data source for google_sql_database_instance  #2841

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 260 insertions(+))
Terraform Beta: Diff ( 5 files changed, 260 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 260 insertions(+))
Terraform Beta: Diff ( 5 files changed, 260 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 260 insertions(+))
Terraform Beta: Diff ( 5 files changed, 260 insertions(+))

@edwardmedia
Update sql_database_instance.html.markdown
3f6a299 
Fixed  docs. 1) removed a link 2) move project and region to Argument section
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 258 insertions(+))
Terraform Beta: Diff ( 5 files changed, 258 insertions(+))

@edwardmedia edwardmedia requested a review from slevenick July 13, 2020 23:36
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 258 insertions(+))
Terraform Beta: Diff ( 5 files changed, 258 insertions(+))

@slevenick slevenick self-requested a review July 15, 2020 22:59
@slevenick slevenick merged commit f7ba084 into GoogleCloudPlatform:master Jul 15, 2020
This was referenced Jul 15, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slevenick slevenick slevenick approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add data source for google_sql_database_instance
4 participants
@edwardmedia @modular-magician @slevenick @googlebot