-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guess at config_id value so that updates don't break downstream resources. #3723
Guess at config_id value so that updates don't break downstream resources. #3723
Conversation
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=129583" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that would have failed but now passes?
I am genuinely not sure if I can. I can try! |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFolderIamAuditConfig_multiple You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=129584" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=129587" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=129589" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccEndpointsService_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=129592" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=129593" |
Cool, that passes and would have crashed before. |
Release Note Template for Downstream PRs (will be copied)
Fixes hashicorp/terraform-provider-google#6713.