-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add desc to schema for google_compute_instance_template #3648
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @c2thorn, please review this PR or find an appropriate assignee. |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=120790" |
@@ -66,14 +66,16 @@ func resourceComputeInstanceTemplate() *schema.Resource { | |||
Computed: true, | |||
ForceNew: true, | |||
ConflictsWith: []string{"name_prefix"}, | |||
ValidateFunc: validateGCPName, | |||
ValidateFunc: validateGCPName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you converted from tabs to spaces in your changes, do you mind reverting it to keep consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am using VIM on remote linux, not sure where to config tabs to spaces. From that editor, I can't see tabs and spaces. I clicked enter
from the above line, which leads to this. This is erb file, I can't run go fmt.
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @c2thorn, please review this PR or find an appropriate assignee. |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=120795" |
Part of hashicorp/terraform-provider-google#6105
Release Note Template for Downstream PRs (will be copied)