Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new network peering fields #3630

Merged

Conversation

danawillow
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#6266

Release Note Template for Downstream PRs (will be copied)

* added `export_subnet_routes_with_public_ip` and `import_subnet_routes_with_public_ip` to `google_compute_network_peering`

@danawillow danawillow force-pushed the tf-6266-network-peering branch from 89d1822 to 0583daa Compare June 11, 2020 23:35
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 81 insertions(+), 95 deletions(-))
Terraform Beta: Diff ( 3 files changed, 81 insertions(+), 95 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=119562"

@danawillow danawillow requested a review from megan07 June 12, 2020 00:08
@danawillow danawillow merged commit db32913 into GoogleCloudPlatform:master Jun 13, 2020
@danawillow danawillow deleted the tf-6266-network-peering branch June 13, 2020 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add exportSubnetRoutesWithPublicIp and importSubnetRoutesWithPublicIp to google_compute_network_peering
4 participants