add default_route_action to compute_url_map

[megan07]

Fixes hashicorp/terraform-provider-google#6205
And adds the extra fields in default_route_action as well.

Release Note Template for Downstream PRs (will be copied)

compute: added `default_route_action` to `compute_url_map` and `compute_url_map.path_matchers`

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 8291 insertions(+), 3822 deletions(-))
Terraform Beta: Diff ( 3 files changed, 8291 insertions(+), 3822 deletions(-))
Ansible: Diff ( 2 files changed, 3734 insertions(+), 608 deletions(-))
TF Conversion: Diff ( 1 file changed, 1360 insertions(+), 53 deletions(-))
Inspec: Diff ( 35 files changed, 1516 insertions(+))

[emilymye]

added @slevenick and @rambleraptor for inspec and ansible

[emilymye]

do you mind linking to an issue number or issue here?

[emilymye]

should we add send_empty values? I'm guessing that if we do add it, it will always send zero which is not really what we want, but I don't think we can unweigh things then. Might just be a limitation we have to live with, backendService is the same way.

[megan07]

i tried adding them in here, but i get an error when defaultService is set because they're conflicting, so we might just have to work with it like this.

[emilymye]

should this be an int like nanos?

[megan07]

The api lists it as string (int64 format) and i saw another field similar use string for that. I assumed TypeInt is just int and not int64, but I may have assumed wrong. And now I'm curious if I can use TypeInt for that?

[emilymye]

weird - well, if it works!

[emilymye]

does this field need to be a set?

[megan07]

i think it should be fine as an array - i ran a few tests on it and it seemed to be fine, and also the same retryConditions is on pathMatchers.routeRules.routeAction.retryPolicy.retryConditions as an array, so I feel pretty comfortable that it's been working fine.

[slevenick]

Should be fine from the InSpec side as its only additions

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 8292 insertions(+), 3822 deletions(-))
Terraform Beta: Diff ( 3 files changed, 8292 insertions(+), 3822 deletions(-))
Ansible: Diff ( 2 files changed, 3734 insertions(+), 608 deletions(-))
TF Conversion: Diff ( 1 file changed, 1360 insertions(+), 53 deletions(-))
Inspec: Diff ( 35 files changed, 1516 insertions(+))

[emilymye]

LGTM if the tests look good

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 8292 insertions(+), 3822 deletions(-))
Terraform Beta: Diff ( 3 files changed, 8292 insertions(+), 3822 deletions(-))
Ansible: Diff ( 2 files changed, 3734 insertions(+), 608 deletions(-))
TF Conversion: Diff ( 1 file changed, 1360 insertions(+), 53 deletions(-))
Inspec: Diff ( 35 files changed, 1516 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=118742"

[megan07]

Updated VCR tests - seeds have been recorded: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstreamVcr/118745?