Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post-merge VCR copy step #3583

Merged
merged 10 commits into from
May 29, 2020

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented May 29, 2020

Swap if/else after checking return code. VCR triggers but is not commented on the PR

Add step to copy cassettes that were recorded on a PR to master after it has been merged. Also cleans up old cassettes

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Ansible: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Ansible: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@slevenick slevenick requested a review from nat-henderson May 29, 2020 16:19
@slevenick slevenick changed the title Test PR Add post-merge VCR copy step May 29, 2020
@slevenick slevenick requested review from nat-henderson and removed request for nat-henderson May 29, 2020 20:22
@slevenick slevenick merged commit c65fb31 into GoogleCloudPlatform:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants