-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support containeranalysis Note and Occurence for attestation #3564
Support containeranalysis Note and Occurence for attestation #3564
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 418 insertions(+), 4 deletions(-)) |
31d29d8
to
59f5fc3
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 411 insertions(+), 6 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 12 files changed, 1714 insertions(+), 71 deletions(-)) |
1 similar comment
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 12 files changed, 1714 insertions(+), 71 deletions(-)) |
name = "<%= ctx[:vars]["attestor"] %>" | ||
attestation_authority_note { | ||
note_reference = google_container_analysis_note.note.name | ||
public_keys { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
things to consider as follow up - this might need to be a set? I didn't test it in-depth in this PR but I'd probably split it out anyways
@@ -51,10 +51,12 @@ func BootstrapKMSKeyWithPurpose(t *testing.T, purpose string) bootstrappedKMS { | |||
* a KMS key. | |||
**/ | |||
func BootstrapKMSKeyWithPurposeInLocation(t *testing.T, purpose, locationID string) bootstrappedKMS { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other followup - I also want to rename these methods to have Shared/Default/...
in the name so we know the name is the same across them, or add name param
8ccc9cd
to
26e0316
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 11 files changed, 1699 insertions(+), 70 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only real actionable question is around Occurrence project/noteName field
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 11 files changed, 1699 insertions(+), 70 deletions(-)) |
Release Note Template for Downstream PRs (will be copied)