Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vcr cloud build #3547

Merged
merged 13 commits into from
May 29, 2020
Merged

Vcr cloud build #3547

merged 13 commits into from
May 29, 2020

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented May 20, 2020 •
edited
Loading

Introduces a cloud build job that triggers a (small) VCR test job in teamcity and posts the URL of the resulting build to the PR

Release Note Template for Downstream PRs (will be copied)

@slevenick slevenick requested a review from nat-henderson May 20, 2020 23:50
nat-henderson
nat-henderson approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe in this, but I am not able to test it myself right now - if you feel good about it too, go for it!

@slevenick slevenick merged commit 8888b64 into GoogleCloudPlatform:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nat-henderson nat-henderson nat-henderson approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slevenick @nat-henderson @googlebot