-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add credentials to bigquery connection. #3546
Add credentials to bigquery connection. #3546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this connected to any issues?
Could the cloud_sql
part of the resource ever worked without credentials? It's a little spooky to add a required field to an existing resource.
There we go - tests pass! |
@ndmckinley thanks for this! @rileykarson credential was only added when bigquery connection moved into GA, prior to that the property simply wasn't settable via the api |
Release Note Template for Downstream PRs (will be copied)