add id and replace self_link in docs (part 5 of #5542) #3535

edwardmedia · 2020-05-19T03:29:27Z

Part of hashicorp/terraform-provider-google#5542

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2020-05-19T03:35:28Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 23 files changed, 93 insertions(+), 35 deletions(-))
Terraform Beta: Diff ( 23 files changed, 93 insertions(+), 35 deletions(-))

third_party/terraform/website/docs/r/google_kms_key_ring_iam.html.markdown

third_party/terraform/website/docs/r/google_organization_iam_audit_config.html.markdown

third_party/terraform/website/docs/r/google_project_iam.html.markdown

third_party/terraform/website/docs/r/google_project_service.html.markdown

third_party/terraform/website/docs/r/google_project_organization_policy.html.markdown

third_party/terraform/website/docs/r/google_kms_crypto_key_iam.html.markdown

…tml.markdown Co-authored-by: Sam Levenick <[email protected]>

…arkdown Co-authored-by: Sam Levenick <[email protected]>

…ml.markdown Co-authored-by: Sam Levenick <[email protected]>

modular-magician · 2020-05-19T21:48:05Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 23 files changed, 93 insertions(+), 36 deletions(-))
Terraform Beta: Diff ( 23 files changed, 93 insertions(+), 36 deletions(-))

modular-magician · 2020-05-19T21:48:07Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 23 files changed, 93 insertions(+), 36 deletions(-))
Terraform Beta: Diff ( 23 files changed, 93 insertions(+), 36 deletions(-))

modular-magician · 2020-05-19T21:48:33Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 23 files changed, 93 insertions(+), 36 deletions(-))
Terraform Beta: Diff ( 23 files changed, 93 insertions(+), 36 deletions(-))

modular-magician · 2020-05-19T21:48:49Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 23 files changed, 93 insertions(+), 36 deletions(-))
Terraform Beta: Diff ( 23 files changed, 93 insertions(+), 36 deletions(-))

Remove ids from exported attributes for IAM resources

Update the exported id from {{organization}} to {{org_id}}

modular-magician · 2020-05-20T17:42:36Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 22 files changed, 81 insertions(+), 36 deletions(-))
Terraform Beta: Diff ( 22 files changed, 81 insertions(+), 36 deletions(-))

modular-magician · 2020-05-20T17:43:26Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 22 files changed, 75 insertions(+), 36 deletions(-))
Terraform Beta: Diff ( 22 files changed, 75 insertions(+), 36 deletions(-))

modular-magician · 2020-05-20T17:44:30Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 21 files changed, 69 insertions(+), 36 deletions(-))
Terraform Beta: Diff ( 21 files changed, 69 insertions(+), 36 deletions(-))

modular-magician · 2020-05-20T17:44:39Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 21 files changed, 69 insertions(+), 36 deletions(-))
Terraform Beta: Diff ( 21 files changed, 69 insertions(+), 36 deletions(-))

modular-magician · 2020-05-20T17:48:20Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 21 files changed, 69 insertions(+), 36 deletions(-))
Terraform Beta: Diff ( 21 files changed, 69 insertions(+), 36 deletions(-))

Updated line formatting

third_party/terraform/website/docs/r/google_organization_iam_binding.html.markdown

third_party/terraform/website/docs/r/google_organization_iam_member.html.markdown

third_party/terraform/website/docs/r/google_organization_iam_policy.html.markdown

modular-magician · 2020-05-20T17:55:33Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 21 files changed, 68 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 21 files changed, 68 insertions(+), 34 deletions(-))

Remove the exported id for org related

Remove exported id

Removed exported id

modular-magician · 2020-05-20T19:07:26Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 19 files changed, 60 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 19 files changed, 60 insertions(+), 34 deletions(-))

modular-magician · 2020-05-20T19:08:57Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 17 files changed, 52 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 17 files changed, 52 insertions(+), 34 deletions(-))

modular-magician · 2020-05-20T19:10:23Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 16 files changed, 50 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 16 files changed, 50 insertions(+), 34 deletions(-))

modular-magician · 2020-05-20T19:10:33Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 16 files changed, 50 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 16 files changed, 50 insertions(+), 34 deletions(-))

modular-magician · 2020-05-20T19:10:52Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 16 files changed, 50 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 16 files changed, 50 insertions(+), 34 deletions(-))

Removed the exported id

modular-magician · 2020-05-20T19:16:41Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 48 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 15 files changed, 48 insertions(+), 34 deletions(-))

add ids to docs GoogleCloudPlatform#5

9d0e9ed

googlebot added the cla: yes label May 19, 2020

edwardmedia requested review from danawillow and slevenick and removed request for danawillow May 19, 2020 03:39

slevenick reviewed May 19, 2020

View reviewed changes

edwardmedia and others added 5 commits May 19, 2020 14:42

Update third_party/terraform/website/docs/r/google_kms_key_ring_iam.h…

7fbb7f5

…tml.markdown Co-authored-by: Sam Levenick <[email protected]>

Update third_party/terraform/website/docs/r/google_kms_key_ring_iam.h…

6f5d1ad

…tml.markdown Co-authored-by: Sam Levenick <[email protected]>

Update third_party/terraform/website/docs/r/google_kms_key_ring_iam.h…

3b03e3b

…tml.markdown Co-authored-by: Sam Levenick <[email protected]>

Update third_party/terraform/website/docs/r/google_project_iam.html.m…

1f28ae2

…arkdown Co-authored-by: Sam Levenick <[email protected]>

Update third_party/terraform/website/docs/r/google_project_service.ht…

9bf99b9

…ml.markdown Co-authored-by: Sam Levenick <[email protected]>

edwardmedia added 5 commits May 20, 2020 10:36

Update google_kms_crypto_key_iam.html.markdown

6e2faf6

Remove ids from exported attributes for IAM resources

Update google_kms_key_ring_iam.html.markdown

e391dbf

Remove ids from exported attributes for IAM resources

Update google_project_iam.html.markdown

0c1906b

Remove ids from exported attributes for IAM resources

Update google_service_account_iam.html.markdown

da1c0ed

Remove ids from exported attributes for IAM resources

Update google_organization_iam_audit_config.html.markdown

89c25f4

Update the exported id from {{organization}} to {{org_id}}

Update google_kms_crypto_key_iam.html.markdown

7afd836

Updated line formatting

slevenick reviewed May 20, 2020

View reviewed changes

Update google_organization_iam_member.html.markdown

3756f63

Remove the exported id for org related

edwardmedia added 4 commits May 20, 2020 12:02

Update google_organization_iam_audit_config.html.markdown

b50e81a

Remove the exported id for org related

Update google_organization_iam_binding.html.markdown

6ca6abf

Remove exported id

Update google_organization_iam_policy.html.markdown

0cbe6fb

Removed exported id

Update google_organization_policy.html.markdown

5e12e47

Removed exported id

Update google_project_organization_policy.html.markdown

445e2ad

Removed the exported id

edwardmedia requested a review from slevenick May 20, 2020 20:37

slevenick approved these changes May 20, 2020

View reviewed changes

edwardmedia merged commit 2605050 into GoogleCloudPlatform:master May 20, 2020

This was referenced May 20, 2020

add id and replace self_link in docs (part 5 of #5542) hashicorp/terraform-provider-google#6437

Merged

add id and replace self_link in docs (part 5 of #5542) hashicorp/terraform-provider-google-beta#2097

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add id and replace self_link in docs (part 5 of #5542) #3535

add id and replace self_link in docs (part 5 of #5542) #3535

edwardmedia commented May 19, 2020

modular-magician commented May 19, 2020

modular-magician commented May 19, 2020

modular-magician commented May 19, 2020

modular-magician commented May 19, 2020

modular-magician commented May 19, 2020

modular-magician commented May 20, 2020

modular-magician commented May 20, 2020

modular-magician commented May 20, 2020

modular-magician commented May 20, 2020

modular-magician commented May 20, 2020

modular-magician commented May 20, 2020

modular-magician commented May 20, 2020

modular-magician commented May 20, 2020

modular-magician commented May 20, 2020

modular-magician commented May 20, 2020

modular-magician commented May 20, 2020

modular-magician commented May 20, 2020

add id and replace self_link in docs (part 5 of #5542) #3535

add id and replace self_link in docs (part 5 of #5542) #3535

Conversation

edwardmedia commented May 19, 2020

modular-magician commented May 19, 2020

Diff report:

modular-magician commented May 19, 2020

Diff report:

modular-magician commented May 19, 2020

Diff report:

modular-magician commented May 19, 2020

Diff report:

modular-magician commented May 19, 2020

Diff report:

modular-magician commented May 20, 2020

Diff report:

modular-magician commented May 20, 2020

Diff report:

modular-magician commented May 20, 2020

Diff report:

modular-magician commented May 20, 2020

Diff report:

modular-magician commented May 20, 2020

Diff report:

modular-magician commented May 20, 2020

Diff report:

modular-magician commented May 20, 2020

Diff report:

modular-magician commented May 20, 2020

Diff report:

modular-magician commented May 20, 2020

Diff report:

modular-magician commented May 20, 2020

Diff report:

modular-magician commented May 20, 2020

Diff report:

modular-magician commented May 20, 2020

Diff report: