Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud app armor: Maximum number of src_ip_ranges is 10 #3516

Merged
merged 1 commit into from
May 15, 2020
Merged

cloud app armor: Maximum number of src_ip_ranges is 10 #3516

merged 1 commit into from
May 15, 2020

Conversation

redbaron
Copy link
Contributor

@redbaron redbaron commented May 15, 2020 •
edited
Loading 

google_compute_security_policy: raise limit on number of  srcIpRange values to supported 10

Upstreams: hashicorp/terraform-provider-google#6393

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@danawillow, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@danawillow danawillow mentioned this pull request May 15, 2020
Closed
danawillow
danawillow approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @redbaron!

@danawillow danawillow merged commit 1ba53cf into GoogleCloudPlatform:master May 15, 2020
@redbaron redbaron deleted the patch-14 branch May 15, 2020 18:42
@redbaron
Copy link
Contributor Author

@danawillow , not sure you are the right person to ask, but any chance official API docs can be updated to mention this limit? https://cloud.google.com/compute/docs/reference/rest/beta/securityPolicies

This was referenced May 15, 2020
Merged
Merged
@danawillow
Copy link
Contributor

That's a different team's responsibility, but I filed a request against them!

nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@redbaron
cloud app armor: Maximum number of src_ip_ranges is 10 (GoogleCloudPl…
d544820 
…atform#3516)
reinoudk added a commit to reinoudk/magic-modules that referenced this pull request Aug 3, 2020
@reinoudk
Update compute_security_policy docs to match src_ip_ranges constraints
4d26009 
The limit of 5 IP ranges per rule was increased to 10 in GoogleCloudPlatform#3516. This commit updates the
related documentation.
@reinoudk reinoudk mentioned this pull request Aug 3, 2020
Merged
danawillow pushed a commit that referenced this pull request Aug 3, 2020
@reinoudk
Update compute_security_policy docs to match src_ip_ranges constraints (
3e642c3 
#3808)

The limit of 5 IP ranges per rule was increased to 10 in #3516. This commit updates the
related documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danawillow danawillow danawillow approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@redbaron @modular-magician @danawillow @googlebot