Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window based SLI #3510

Merged
merged 2 commits into from
May 14, 2020
Merged

Conversation

emilymye
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

monitoring: Added window-based SLI to `google_monitoring_slo`

@emilymye emilymye requested a review from danawillow May 13, 2020 21:49
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 2363 insertions(+), 178 deletions(-))
Terraform Beta: Diff ( 4 files changed, 2363 insertions(+), 178 deletions(-))
TF Conversion: Diff ( 1 file changed, 440 insertions(+))
TF OiCS: Diff ( 16 files changed, 509 insertions(+))

@emilymye emilymye requested a review from slevenick May 13, 2020 21:54
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's going to be a bit weird on the docs since there are a few nested object types that appear multiple times ("the 'X' block supports") but I don't know that there's anything we can really do about it, so I'm fine.

Exactly one of the following must be set:
`basic_sli`, `request_based_sli`, `windows_based_sli`
properties:
# NOTE: If adding properties to requestBasedSli, remember to add to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# NOTE: If adding properties to requestBasedSli, remember to add to the
# NOTE: If adding properties to windowsBasedSli, remember to add to the

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 2363 insertions(+), 178 deletions(-))
Terraform Beta: Diff ( 4 files changed, 2363 insertions(+), 178 deletions(-))
TF Conversion: Diff ( 1 file changed, 440 insertions(+))
TF OiCS: Diff ( 16 files changed, 509 insertions(+))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants