-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add window based SLI #3510
Add window based SLI #3510
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 2363 insertions(+), 178 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's going to be a bit weird on the docs since there are a few nested object types that appear multiple times ("the 'X' block supports") but I don't know that there's anything we can really do about it, so I'm fine.
products/monitoring/api.yaml
Outdated
Exactly one of the following must be set: | ||
`basic_sli`, `request_based_sli`, `windows_based_sli` | ||
properties: | ||
# NOTE: If adding properties to requestBasedSli, remember to add to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# NOTE: If adding properties to requestBasedSli, remember to add to the | |
# NOTE: If adding properties to windowsBasedSli, remember to add to the |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 2363 insertions(+), 178 deletions(-)) |
* add window based SLI * comment
Release Note Template for Downstream PRs (will be copied)