Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GKE release channel updates #3509

Merged
merged 1 commit into from
May 13, 2020

Conversation

rileykarson
Copy link
Member

Fixes hashicorp/terraform-provider-google#5846

The field I exposed on the datasource doesn't match the API 1:1 (which is a list of objects. repeated message in proto, I bet), but should prove much more useful overall- as you can see in the test, it's simple to look up the version for the channel and advance to it.

Release Note Template for Downstream PRs (will be copied)

container: added update support to `google_container_cluster`'s `release_channel` field (`google-beta` only)
container: added the ability to unspecify `google_container_cluster`'s `min_master_version` field
container: added `release_channel_default_version` to `data.google_container_engine_versions`, allowing you to find the default version for a release channel (`google-beta` only)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 23 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 5 files changed, 111 insertions(+), 30 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add update support for google_container_cluster.release_channel
4 participants