Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Terraform] Store SHA 256 of certificate SSL private keys #3376

Closed
wants to merge 2 commits into from

Conversation

hyww
Copy link
Contributor

@hyww hyww commented Apr 14, 2020

related issue:

custom_flatten introduced in #1336 doesn't work for privateKey field since it has ignore_read set to true. Use state_func instead.

see also: hashicorp/terraform-provider-google#2976

both the custom_flatten function and sha256DiffSuppress were removed because:

  • there seems no other usage of those functions
  • usage of Sum is not correct in those functions

Release Note Template for Downstream PRs (will be copied)


`custom_flatten` doesn't work for `privateKey` field since it has
`ignore_read` set to true. Use `state_func` instead.
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@emilymye, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 25 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 4 files changed, 25 insertions(+), 20 deletions(-))

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 26 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 4 files changed, 26 insertions(+), 20 deletions(-))

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@danawillow danawillow self-requested a review April 21, 2020 22:36
@danawillow
Copy link
Contributor

This PR looks good functionally, but it doesn't conform to the state-setting model that we'll eventually need to adhere to (more info in hashicorp/terraform-provider-google#4328). I've reached out to try to get more information on what we can do here.

@danawillow
Copy link
Contributor

Ok, I've heard back from HashiCorp, and it's pretty much what I expected- future versions of the SDK won't allow having a value in the config but not in state. Because of this, I don't think it's worth temporarily fixing this use case when we won't be able to in the future. Sorry about this! I wish I had better news for you. Feel free to file an issue in https://github.com/hashicorp/terraform-plugin-sdk if you want to follow up with the people working on the SDK.

Closing this out.

@danawillow danawillow closed this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants