-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [Terraform] Store SHA 256 of certificate SSL private keys #3376
Conversation
`custom_flatten` doesn't work for `privateKey` field since it has `ignore_read` set to true. Use `state_func` instead.
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @emilymye, please review this PR or find an appropriate assignee. |
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
This PR looks good functionally, but it doesn't conform to the state-setting model that we'll eventually need to adhere to (more info in hashicorp/terraform-provider-google#4328). I've reached out to try to get more information on what we can do here. |
Ok, I've heard back from HashiCorp, and it's pretty much what I expected- future versions of the SDK won't allow having a value in the config but not in state. Because of this, I don't think it's worth temporarily fixing this use case when we won't be able to in the future. Sorry about this! I wish I had better news for you. Feel free to file an issue in https://github.com/hashicorp/terraform-plugin-sdk if you want to follow up with the people working on the SDK. Closing this out. |
related issue:
custom_flatten
introduced in #1336 doesn't work forprivateKey
field since it hasignore_read
set totrue
. Usestate_func
instead.see also: hashicorp/terraform-provider-google#2976
both the
custom_flatten
function andsha256DiffSuppress
were removed because:Sum
is not correct in those functionsRelease Note Template for Downstream PRs (will be copied)