Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC SC dry-run mode #3353

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Conversation

drebes
Copy link
Member

@drebes drebes commented Apr 7, 2020

Release Note Template for Downstream PRs (will be copied)

accesscontextmanager: added `spec` and `use_explicit_dry_run_spec` to `google_access_context_manager_service_perimeter` to test perimeter configurations in dry-run mode.

@drebes drebes requested a review from rileykarson April 7, 2020 18:13
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 425 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 425 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 102 insertions(+))
Inspec: Diff ( 6 files changed, 109 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 433 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 433 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 102 insertions(+))
Inspec: Diff ( 6 files changed, 109 insertions(+))

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants