Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move deleted project check into project service read #3350

Merged

Conversation

danawillow
Copy link
Contributor

@danawillow danawillow commented Apr 6, 2020

Previously the check occurred in the list call, which was called in Create and Read. There's no good reason why a user should be trying to set a new service enabled on a deleted project, so I just moved the check to only happen on read.

Fixes hashicorp/terraform-provider-google#6013.

Release Note Template for Downstream PRs (will be copied)

* serviceusage: fixed issue where `google_project_services` attempted to read a project before enabling the API that allows that read

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 15 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 2 files changed, 15 insertions(+), 14 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 16 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 2 files changed, 16 insertions(+), 15 deletions(-))

@danawillow danawillow requested a review from c2thorn April 6, 2020 23:05
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution to this side effect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_project_service 403 - not enabling API
4 participants