Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set master_authorized_networks_config.enabled=true ... #2939

Conversation

yukinying
Copy link
Contributor

…when there is a master_authorized_networks_config block in terraform-google-conversion. This aligns with how terraform-google-provider handles master_authorized_networks_config block.

if len(l) == 0 {
return &containerBeta.MasterAuthorizedNetworksConfig{
Enabled: false,
}
}
result := &containerBeta.MasterAuthorizedNetworksConfig{
Enabled: true,
}

Release Note Template for Downstream PRs (will be copied)

terraform-google-conversion only: set master_authorized_networks_config.enabled to true when there is a master_authorized_networks_config block in Terraform configuration.

@yukinying
Copy link
Contributor Author

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 1682f34.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: GoogleCloudPlatform/terraform-google-conversion#309

@yukinying
Copy link
Contributor Author

// cc @chrisst

Copy link
Contributor

@chrisst chrisst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants