Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow domain mapping to succeed if DNS is pending #2917

Merged

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Jan 4, 2020

This now mimics the gcloud behavior where the resource creation "succeeds" even though it's still in a ready:unknown state.

Fixes hashicorp/terraform-provider-google#5278

Release Note Template for Downstream PRs (will be copied)

`cloudrun`: Stopped returning an error when a `cloud_run_domain_mapping` was waiting on DNS verification.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a30c9bf.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1587
depends: hashicorp/terraform-provider-google#5315

@chrisst
Copy link
Contributor Author

chrisst commented Jan 4, 2020

supersedes #2915

@chrisst chrisst force-pushed the domain-mapping-pending2 branch from a30c9bf to 30d6ee7 Compare January 6, 2020 23:03
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 30d6ee7.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

chrisst and others added 2 commits January 6, 2020 23:54
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the domain-mapping-pending2 branch from 30d6ee7 to dbcd034 Compare January 6, 2020 23:54
@modular-magician modular-magician merged commit 764c68b into GoogleCloudPlatform:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TestAccCloudRunDomainMapping_cloudRunDomainMappingBasicExample
4 participants