Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update network peering docs, schema #2745

Merged
merged 3 commits into from
Nov 25, 2019
Merged

Update network peering docs, schema #2745

merged 3 commits into from
Nov 25, 2019

Conversation

rileykarson
Copy link
Member

Fixes hashicorp/terraform-provider-google#4097

Release Note Template for Downstream PRs (will be copied)

@rileykarson rileykarson requested a review from chrisst November 22, 2019 19:33
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 980366a.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1431
depends: hashicorp/terraform-provider-google#4982

chrisst
chrisst approved these changes Nov 22, 2019
View reviewed changes
third_party/terraform/website/docs/r/compute_network_peering.html.markdown Outdated
* `peer_network` - (Required) The peer network in the peering. The peer network
may belong to a different project.

* `export_custom_routes` - (Optional) Whether to export the custom routes to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 fields should be documented as Beta.

@chrisst
Copy link
Contributor

chrisst commented Nov 22, 2019

Once docs are updated LGTM

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 826cfa7.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rileykarson and others added 3 commits November 25, 2019 16:43
@rileykarson @modular-magician
Update network peering docs, schema
429318e
@rileykarson @modular-magician
Add beta indicator
df29d4c
@modular-magician
Update tracked submodules -> HEAD on Mon Nov 25 16:43:48 UTC 2019
8967b5b 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 6595645 into GoogleCloudPlatform:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisst chrisst chrisst approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docs for beta custom routes in google_compute_network_peering
4 participants
@rileykarson @modular-magician @chrisst @googlebot