Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add L7 ILB fields to RegionBackendService #2547

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Add L7 ILB fields to RegionBackendService #2547

merged 2 commits into from
Nov 5, 2019

Conversation

tysen
Copy link

@tysen tysen commented Oct 25, 2019

Release Note Template for Downstream PRs (will be copied)

`google_compute_region_backend_service` now supports L7 ILB (in beta).

@tysen tysen requested a review from rileykarson October 25, 2019 23:28
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 34fbf67.

Pull request statuses

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1311
depends: GoogleCloudPlatform/terraform-google-conversion#240
depends: hashicorp/terraform-provider-google#4772
depends: ansible-collections/google.cloud#38
depends: modular-magician/inspec-gcp#244

rileykarson
rileykarson reviewed Oct 29, 2019
View reviewed changes
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just comments related to adding tests- I want to make sure we exercise every field on the resource that we can.

products/compute/api.yaml Outdated
runtime value should be 1900. Defaults to 1900.
# 'port' is deprecated
- !ruby/object:Api::Type::String
name: 'portName'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't set the scheme to EXTERNAL thought, right? So this can likely be omitted?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. These docs suggest that EXTERNAL regional load balancing systems are possible, but the API currently rejects requests to create a RegionBackendService with loadBalancingScheme set to EXTERNAL with a message ~= "not yet supported".

products/compute/api.yaml Outdated Show resolved Hide resolved
products/compute/api.yaml Show resolved Hide resolved
products/compute/api.yaml Show resolved Hide resolved
products/compute/api.yaml Outdated Show resolved Hide resolved
products/compute/api.yaml Show resolved Hide resolved
@tysen tysen requested a review from rileykarson November 5, 2019 01:29
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c3eb7e5.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 74543af.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Update tracked submodules -> HEAD on Tue Nov 5 21:54:36 UTC 2019
e9ac54c 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 9536005 into GoogleCloudPlatform:master Nov 5, 2019
@modular-magician modular-magician mentioned this pull request Nov 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated inspec terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tysen @modular-magician @rileykarson @googlebot