Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lock policy if it is already locked. #2534

Merged

Conversation

nat-henderson
Copy link
Contributor

@nat-henderson nat-henderson commented Oct 24, 2019

Release Note Template for Downstream PRs (will be copied)

`storage`: Fixed error in `google_storage_bucket` where locked retention policies would cause a bucket to report failure on all updates (even though updates were applied correctly).

Fixes hashicorp/terraform-provider-google#4751

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c74805c.

Pull request statuses

WARNING: The following files changed in commit c74805c may need corresponding changes in third_party/validator:

  • third_party/terraform/resources/resource_storage_bucket.go

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1307
depends: hashicorp/terraform-provider-google#4761

Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@megan07
Copy link
Contributor

megan07 commented Oct 25, 2019

Oh! I would double check this release note as well. To start with storage: and the past tense Fixed I think

nat-henderson and others added 3 commits October 25, 2019 20:03
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit e876e09 into GoogleCloudPlatform:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants