Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This property is not correctly handled on the API - we can work around it here. #2404

Merged
merged 2 commits into from
Oct 1, 2019
Merged

This property is not correctly handled on the API - we can work around it here. #2404

merged 2 commits into from
Oct 1, 2019

Conversation

nat-henderson
Copy link
Contributor

@nat-henderson nat-henderson commented Sep 30, 2019 •
edited
Loading

Release Note Template for Downstream PRs (will be copied)

compute: Added ability to set `quic_override` on `google_compute_https_target_proxy` to empty.

@nat-henderson nat-henderson mentioned this pull request Sep 30, 2019
Closed
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5d0aeff.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1219
depends: hashicorp/terraform-provider-google#4588

@emilymye
Copy link
Contributor

emilymye commented Oct 1, 2019

Changed the release note to be more like what paddy suggests we should do, but feel free to edit!

@emilymye
Copy link
Contributor

emilymye commented Oct 1, 2019

We probably also need to document default but otherwise LGTM

@nat-henderson
Copy link
Contributor Author

The documentation already says we do this, which is not amazing, haha.

nat-henderson and others added 2 commits October 1, 2019 19:56
@nat-henderson @modular-magician
This property is not correctly handled on the API - we can work aroun…
b0939fd 
…d it here.
@modular-magician
Update tracked submodules -> HEAD on Tue Oct 1 19:56:28 UTC 2019
e715355 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 3e5e6ec into master Oct 1, 2019
@nat-henderson nat-henderson deleted the quic-override branch October 1, 2019 19:58
@rileykarson rileykarson mentioned this pull request Nov 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilymye emilymye emilymye approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nat-henderson @modular-magician @emilymye @googlebot