-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning about private-by-default cloud functions #2321
Add warning about private-by-default cloud functions #2321
Conversation
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
environment_variables = { | ||
MY_ENV_VAR = "my-env-var-value" | ||
} | ||
} | ||
|
||
# Add IAM member for a user who can invoke the function (no admin actions) | ||
resource "google_cloudfunctions_function_iam_member" "invoker" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like secure cloud functions to be our default example, but what do you think of adding a second example that shows how to add a publicly invokable fn? That example will simulate the current behaviour for existing users, and I've seen users struggle setting allUsers
permissions in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
third_party/terraform/website/docs/r/cloudfunctions_function.html.markdown
Outdated
Show resolved
Hide resolved
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
1 similar comment
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
cd55e96
to
fb22858
Compare
Release Note for Downstream PRs (will be copied)