Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery Dataset default CMEK encryption #2226

Merged
merged 2 commits into from
Oct 4, 2019

Conversation

drebes
Copy link
Member

@drebes drebes commented Aug 21, 2019

Release Note for Downstream PRs (will be copied)

Adds support for default customer-managed encryption keys (CMEK) for BigQuery datasets.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 1fc0e4656d84ae91372e7b68cf761da817d90578.

Pull request statuses

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1081
depends: GoogleCloudPlatform/terraform-google-conversion#176
depends: hashicorp/terraform-provider-google#4312
depends: modular-magician/ansible#365
depends: modular-magician/inspec-gcp#188

@danawillow
Copy link
Contributor

I'm going to be leaving pretty soon for vacation. Sam, mind taking care of this review?

@rileykarson rileykarson removed the request for review from danawillow August 22, 2019 22:03
@drebes
Copy link
Member Author

drebes commented Oct 2, 2019

Any feedback on this?

@slevenick
Copy link
Contributor

Oh gosh, sorry I dropped the ball on this. Will run the tests and take a look now

@slevenick
Copy link
Contributor

@drebes Looks good! Sorry getting to this took so long.

Can you amend this commit and push it again? I'll need to re-trigger generation to update all the downstreams, then I can merge it

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, e30d0ef.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
InSpec already has an open PR.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: ansible-collections/google.cloud#22

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants