Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible Filestore Instances #2209

Merged
merged 5 commits into from
Aug 20, 2019
Merged

Ansible Filestore Instances #2209

merged 5 commits into from
Aug 20, 2019

Conversation

rambleraptor
Copy link
Contributor

Release Note for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 3a87a55.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1069
depends: GoogleCloudPlatform/terraform-google-conversion#171
depends: hashicorp/terraform-provider-google#4295

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b8973de.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/ansible#360

@rambleraptor rambleraptor requested review from rileykarson and SirGitsalot and removed request for rileykarson August 19, 2019 23:13
SirGitsalot
SirGitsalot approved these changes Aug 20, 2019
View reviewed changes
products/filestore/ansible.yaml Outdated
@@ -0,0 +1,28 @@
# Copyright 2017 Google Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2019

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c946d8d.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rambleraptor and others added 5 commits August 20, 2019 18:17
@rambleraptor @modular-magician
wip
a16b203
@rambleraptor @modular-magician
stray delete
432aac5
@rambleraptor @modular-magician
tests pass
32f3505
@rambleraptor @modular-magician
pr comment
d2f8c63
@modular-magician
Update tracked submodules -> HEAD on Tue Aug 20 18:17:21 UTC 2019
0ea6fb8 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit fc0d197 into master Aug 20, 2019
@modular-magician modular-magician mentioned this pull request Aug 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirGitsalot SirGitsalot SirGitsalot approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rambleraptor @modular-magician @SirGitsalot @googlebot