Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BAA key ids computed. #2176

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Make BAA key ids computed. #2176

merged 2 commits into from
Aug 14, 2019

Conversation

paddycarver
Copy link
Contributor

Binary authorization attestor key IDs can be set by the server, so they
need to be computed.

Release Note for Downstream PRs (will be copied)

binary_authorization: don't diff when attestation authority note public keys don't have an ID in the config

@paddycarver paddycarver requested a review from danawillow August 13, 2019 23:19
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 48d8ee4a9dfdd2d57330b03347d2cedd99123666.

Pull request statuses

No diff detected in Ansible.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1042
depends: GoogleCloudPlatform/terraform-google-conversion#160
depends: hashicorp/terraform-provider-google#4246
depends: modular-magician/inspec-gcp#181

@danawillow
Copy link
Contributor

Something strange and terrible has happened to the downstream PRs. Rebase and try again?

@paddycarver paddycarver force-pushed the paddy_binary_auth_attestor_key_id branch from 48d8ee4 to cfa8fb7 Compare August 14, 2019 00:43
@paddycarver
Copy link
Contributor Author

I wish I was deleting that much code...

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, cfa8fb7.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@paddycarver
Copy link
Contributor Author

We're back down to a reasonable diff.

paddycarver and others added 2 commits August 14, 2019 01:24
@paddycarver @modular-magician
Make BAA key ids computed.
9b66d9a 
Binary authorization attestor key IDs can be set by the server, so they
need to be computed.
@modular-magician
Update tracked submodules -> HEAD on Wed Aug 14 01:24:49 UTC 2019
fb92a20 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the paddy_binary_auth_attestor_key_id branch from cfa8fb7 to fb92a20 Compare August 14, 2019 01:24
@modular-magician modular-magician merged commit 05286fd into GoogleCloudPlatform:master Aug 14, 2019
@SarahFrench SarahFrench deleted the paddy_binary_auth_attestor_key_id branch March 26, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danawillow danawillow danawillow approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated inspec terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paddycarver @modular-magician @danawillow @googlebot