Terraform generate iam #2006

slevenick · 2019-07-02T22:10:27Z

fixes: hashicorp/terraform-provider-google#2889
Add support for generating IAM resources to MM. This PR converts pubsub_topic_iam_* and adds new resources for source_repo_repository_iam_*

Release Note for Downstream PRs (will be copied)

google_sourcerepo_repository_iam_* Add support for source repo repository IAM resources

modular-magician · 2019-07-02T22:42:37Z

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of dd409a0.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#914
depends: GoogleCloudPlatform/terraform-google-conversion#122
depends: hashicorp/terraform-provider-google#3961

modular-magician · 2019-07-02T22:53:26Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 4aafdf2.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-02T22:59:08Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9b538a9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-02T23:12:36Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 7a0b0b9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

drebes · 2019-07-03T05:30:43Z

This is great! I was working on something similar last week but didn't get half as far as this. Looking forward to have this in to start contributing some new IAM resources.

modular-magician · 2019-07-03T17:48:58Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 64b9d9c.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rileykarson

Looking good so far! I made a first pass, most of my comments are just nitpicks or have to do with primary_resource_name. I focused mostly on the generated tests (🔥 🔥) so far, I'm waiting for the rename to hit the downstreams to dig more into the resource files when I can easily compare this to handwritten ones.

templates/terraform/examples/base_configs/iam_test_file.go.erb

api/resource/iam_policy.rb

templates/terraform/examples/base_configs/iam_test_file.go.erb

templates/terraform/iam_policy.go.erb

templates/terraform/provider_gen.erb

templates/terraform/resource_iam.html.markdown.erb

rileykarson · 2019-07-08T21:22:13Z

templates/terraform/resource_iam.html.markdown.erb

+}
+
+resource "<%= terraform_name -%>_policy" "editor" {
+  <%= object.name.underscore -%>       = "<%= object.id_format.gsub('{{name}}', "{{#{object.name.underscore}}}")-%>"


Is the change to partial URI in pubsub intentional? Will specifying that work? https://github.com/terraform-providers/terraform-provider-google-beta/pull/914/files#diff-5bc4b7188e596ed679a95ddfd0c495c2R45

Yeah, I believe changing to the partial URI makes the tests and examples more deterministic. Currently the pubsub topic IAM resources allow many different ways of specifying the topic that is the subject of IAM policies. For example topic = "topic-name" uses the default project, but still works. Tests of these different ways of declaring it can be found here: https://github.com/terraform-providers/terraform-provider-google-beta/blob/master/google-beta/resource_pubsub_topic_iam_test.go and are still being used to test the generated version

It makes sense to me to be as specific as possible in test/example code rather than leaving the project unspecified. It also allows for the generation to be more generic

I'd guess that most users expect to use short names, and so I lean slightly more towards short names than partial URIs. That said, not strongly enough to block- the distinction doesn't end up mattering much, and it's easier for us if users specify the partial URI as well.

modular-magician · 2019-07-08T21:28:45Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, db406cd.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-09T00:12:27Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d4aecf9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-09T17:02:40Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, f5f6d85.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-09T17:02:44Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, f5f6d85.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rileykarson

LGTM! Just a few small things.

templates/terraform/iam_policy.go.erb

templates/terraform/resource_iam.html.markdown.erb

rileykarson · 2019-07-09T17:13:46Z

templates/terraform/resource_iam.html.markdown.erb

+}
+
+resource "<%= terraform_name -%>_policy" "editor" {
+  <%= object.name.underscore -%>       = "<%= object.id_format.gsub('{{name}}', "{{#{object.name.underscore}}}")-%>"


I'd guess that most users expect to use short names, and so I lean slightly more towards short names than partial URIs. That said, not strongly enough to block- the distinction doesn't end up mattering much, and it's easier for us if users specify the partial URI as well.

modular-magician · 2019-07-10T17:16:35Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 71f7439.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-10T17:17:00Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 8d0c6a0.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-10T17:29:39Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c9cc2c6.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-10T17:37:21Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 82c2ecc.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-10T20:43:41Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c62ec3e.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Co-Authored-By: Riley Karson <[email protected]>

modular-magician · 2019-07-10T20:56:46Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 0b1d4f4.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-10T21:11:03Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 8c7c5ee.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

googlebot added the cla: yes label Jul 2, 2019

slevenick force-pushed the terraform-generate-iam branch 2 times, most recently from 1cda4ee to dd409a0 Compare July 2, 2019 22:32

modular-magician added downstream-generated terraform-google-conversion terraform-provider-google-beta terraform-provider-google labels Jul 2, 2019

slevenick force-pushed the terraform-generate-iam branch from 9b538a9 to 7a0b0b9 Compare July 2, 2019 22:59

slevenick requested a review from rileykarson July 3, 2019 21:29

rileykarson reviewed Jul 8, 2019

View reviewed changes

rileykarson approved these changes Jul 9, 2019

View reviewed changes

slevenick force-pushed the terraform-generate-iam branch from c9cc2c6 to 82c2ecc Compare July 10, 2019 17:26

slevenick force-pushed the terraform-generate-iam branch from 82c2ecc to c62ec3e Compare July 10, 2019 20:31

slevenick added 2 commits July 10, 2019 13:44

Adding generate for pubsub iam

b3c3264

More work on iam policy

55e812d

slevenick and others added 14 commits July 10, 2019 13:44

Generating pubsub topic iam

919826e

Test generation sort of working

f62064a

Add iam generation for source repo

00dbe52

Rename methods

23e57e2

Provider core define empty generate_iam_policy method

b1fd5d3

Remove log line

02516b7

Add empty method to terraform conversion

0a95fc4

Add generated iam docs

c7680d6

Rename generated iam resources

6ef4675

Apply suggestions from code review

6f35ea5

Co-Authored-By: Riley Karson <[email protected]>

PR feedback, renaming, move primary_resource_name to terraform example

0cceea1

Remove extra primary_resource_name

5fec73f

Add comment for why we set "project"

00c86ed

Co-Authored-By: Riley Karson <[email protected]>

Add qualifyUrl as method on updater

0ea30c7

slevenick force-pushed the terraform-generate-iam branch from c62ec3e to 0b1d4f4 Compare July 10, 2019 20:45

slevenick added the changelog: new-resource label Jul 10, 2019

Typo

8c7c5ee

slevenick force-pushed the terraform-generate-iam branch from 0b1d4f4 to 8c7c5ee Compare July 10, 2019 20:59

modular-magician added the automerged label Jul 10, 2019

Update tracked submodules -> HEAD on Wed Jul 10 21:18:48 UTC 2019

fb6dbe1

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician merged commit ccfda0a into GoogleCloudPlatform:master Jul 10, 2019

drebes mentioned this pull request Aug 20, 2019

adds google_sourcerepo_repository_iam_* to the sidebar #2218

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Terraform generate iam #2006

Terraform generate iam #2006

slevenick commented Jul 2, 2019 •

edited

Loading

modular-magician commented Jul 2, 2019

modular-magician commented Jul 2, 2019

modular-magician commented Jul 2, 2019

modular-magician commented Jul 2, 2019

drebes commented Jul 3, 2019

modular-magician commented Jul 3, 2019

rileykarson left a comment

rileykarson Jul 8, 2019

slevenick Jul 9, 2019

rileykarson Jul 9, 2019

modular-magician commented Jul 8, 2019

modular-magician commented Jul 9, 2019

modular-magician commented Jul 9, 2019

modular-magician commented Jul 9, 2019

rileykarson left a comment

rileykarson Jul 9, 2019

modular-magician commented Jul 10, 2019

modular-magician commented Jul 10, 2019

modular-magician commented Jul 10, 2019

modular-magician commented Jul 10, 2019

modular-magician commented Jul 10, 2019

modular-magician commented Jul 10, 2019

modular-magician commented Jul 10, 2019

Terraform generate iam #2006

Terraform generate iam #2006

Conversation

slevenick commented Jul 2, 2019 • edited Loading

Release Note for Downstream PRs (will be copied)

modular-magician commented Jul 2, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 2, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 2, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 2, 2019

Pull request statuses

New Pull Requests

drebes commented Jul 3, 2019

modular-magician commented Jul 3, 2019

Pull request statuses

New Pull Requests

rileykarson left a comment

Choose a reason for hiding this comment

rileykarson Jul 8, 2019

Choose a reason for hiding this comment

slevenick Jul 9, 2019

Choose a reason for hiding this comment

rileykarson Jul 9, 2019

Choose a reason for hiding this comment

modular-magician commented Jul 8, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 9, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 9, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 9, 2019

Pull request statuses

New Pull Requests

rileykarson left a comment

Choose a reason for hiding this comment

rileykarson Jul 9, 2019

Choose a reason for hiding this comment

modular-magician commented Jul 10, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 10, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 10, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 10, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 10, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 10, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 10, 2019

Pull request statuses

New Pull Requests

slevenick commented Jul 2, 2019 •

edited

Loading