Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes_dashboard is disabled by default #1986

Merged
merged 3 commits into from
Jun 27, 2019

Conversation

danawillow
Copy link
Contributor

@danawillow danawillow commented Jun 26, 2019

Mentioned in a comment in the original PR, but the change to the resource file doesn't really do anything at the moment since we have a bug causing a crash when an empty block is added, and that's the only way for this default to show up. However, since the API-side default is now to disable by default, it's still worth adding this for the docs changes (and in case that bug ever gets fixed)

Upstreams hashicorp/terraform-provider-google#3011.

Release Note for Downstream PRs (will be copied)

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 48e3d24.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#902
depends: hashicorp/terraform-provider-google#3931

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GKE 1.11 (which is available for another ~1.5mo) doesn't disable this by default, 1.12+ do though. It's a good idea to make this the TF default regardless, and this isn't a breaking change because nobody could have specified kubernetes_dashboard {} before.

@modular-magician modular-magician merged commit 20ff257 into GoogleCloudPlatform:master Jun 27, 2019
@danawillow danawillow deleted the tf-3011 branch June 27, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants