Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible: gcp_iam_service_account_key: python3 TypeError - add decode to variable assignment #1895

Merged

Conversation

cscheib
Copy link
Contributor

@cscheib cscheib commented Jun 7, 2019

One of (at least) two possible solutions to: #1893

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@cscheib cscheib changed the title WIP: add decode to variable assignment WIP: Ansible: gcp_iam_service_account_key: python3 TypeError - add decode to variable assignment Jun 7, 2019
Copy link
Contributor

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danawillow danawillow requested a review from rambleraptor June 12, 2019 16:22
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 9f9ad76.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/ansible#286

@cscheib cscheib changed the title WIP: Ansible: gcp_iam_service_account_key: python3 TypeError - add decode to variable assignment Ansible: gcp_iam_service_account_key: python3 TypeError - add decode to variable assignment Jun 22, 2019
@cscheib
Copy link
Contributor Author

cscheib commented Jun 22, 2019

@rambleraptor @danawillow
I'm a little unclear as to the process here, if there are any actions I can/should take to push this alone, please let me know!

@rambleraptor
Copy link
Contributor

Hi @cscheib. We just had to rebase this off of master and re-run it through our CI system. This should be merged in today!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, aeb8e9f.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants