Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log_config block to router_nat #1806

Merged
merged 2 commits into from
May 24, 2019
Merged

Add log_config block to router_nat #1806

merged 2 commits into from
May 24, 2019

Conversation

tysen
Copy link

@tysen tysen commented May 21, 2019

Fixes hashicorp/terraform-provider-google#3548


[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@tysen tysen requested a review from danawillow May 21, 2019 20:48
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of a0064e42eba50b3dad05e5c21945099dfce9e457.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#743
depends: hashicorp/terraform-provider-google#3684

@danawillow
Copy link
Contributor

oh whoops left comments on the downstream: hashicorp/terraform-provider-google#3684 (review)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, eec84bc.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Ty Larrabee and others added 2 commits May 24, 2019 21:03
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit fb0c876 into GoogleCloudPlatform:master May 24, 2019
@tysen tysen deleted the nat_logging_hw branch May 24, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling logging for Cloud NAT
4 participants