Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (sub)network to dataflow job #1677

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Add (sub)network to dataflow job #1677

merged 2 commits into from
Apr 25, 2019

Conversation

tysen
Copy link

@tysen tysen commented Apr 22, 2019

Fix for hashicorp/terraform-provider-google#3332.


[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 7bfb74bc582a335abdbf22e50b95a60be5a7f4fa.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#631
depends: hashicorp/terraform-provider-google#3476

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far! My comments are mostly about convention, if you have any questions about them feel free to ask.

@rileykarson
Copy link
Member

Looks the Magician got confused, can you run git commit --amend --no-edit and force push again?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d1103dc.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@rileykarson
Copy link
Member

Looks like Travis is unhappy downstream. Can you fix these errors? https://travis-ci.org/terraform-providers/terraform-provider-google-beta/builds/524181200#L486

You can run make lint in the TF repo to verify locally if you'd like.

@tysen
Copy link
Author

tysen commented Apr 24, 2019 via email

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d7af1bf.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Ty Larrabee and others added 2 commits April 25, 2019 16:04
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants