-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (sub)network to dataflow job #1677
Conversation
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great so far! My comments are mostly about convention, if you have any questions about them feel free to ask.
Looks the Magician got confused, can you run |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Looks like Travis is unhappy downstream. Can you fix these errors? https://travis-ci.org/terraform-providers/terraform-provider-google-beta/builds/524181200#L486 You can run |
Sure will.
…On Wed, Apr 24, 2019 at 2:01 PM Riley Karson ***@***.***> wrote:
Looks like Travis is unhappy downstream. Can you fix these errors?
https://travis-ci.org/terraform-providers/terraform-provider-google-beta/builds/524181200#L486
You can run make lint in the TF repo to verify locally if you'd like.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1677 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALORCTHDCHXJ5OI2QJPY5LPSDDBDANCNFSM4HHTMOQA>
.
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Fix for hashicorp/terraform-provider-google#3332.
[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]