Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform: Make private Cloud DNS GA #1600

Merged
merged 2 commits into from
Apr 1, 2019
Merged

Terraform: Make private Cloud DNS GA #1600

merged 2 commits into from
Apr 1, 2019

Conversation

drebes
Copy link
Member

@drebes drebes commented Mar 30, 2019

[all]

[terraform]

Private Cloud DNS zones

[terraform-beta]

[ansible]

[inspec]

@drebes
Copy link
Member Author

drebes commented Mar 30, 2019

Note: TestAccDnsManagedZone_privateUpdate is still flaky due to the issue with the double nested object update.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@rileykarson rileykarson self-requested a review April 1, 2019 16:02
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 1a450a0.

Pull request statuses

No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#571
depends: GoogleCloudPlatform/terraform-google-conversion#41
depends: hashicorp/terraform-provider-google#3352
depends: modular-magician/ansible#224

rileykarson
rileykarson approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform LGTM, just waiting on an ack from @rambleraptor for Ansible 👍

drebes and others added 2 commits April 1, 2019 17:56
@drebes @modular-magician
Terraform: Private Cloud DNS zones are now GA
704fe5f
@modular-magician
Update tracked submodules -> HEAD on Mon Apr 1 17:56:45 UTC 2019
f0ce094 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the terraform-private-dns-ga branch from 1a450a0 to f0ce094 Compare April 1, 2019 17:56
@modular-magician modular-magician merged commit d31ad24 into GoogleCloudPlatform:master Apr 1, 2019
@modular-magician modular-magician mentioned this pull request Apr 2, 2019
Merged
@drebes drebes deleted the terraform-private-dns-ga branch March 13, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes community downstream-generated terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drebes @modular-magician @rileykarson @googlebot