Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make forwarding rule service_label and service_name GA #1584

Merged
merged 4 commits into from
Mar 28, 2019
Merged

Make forwarding rule service_label and service_name GA #1584

merged 4 commits into from
Mar 28, 2019

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Mar 27, 2019 •
edited
Loading

[all]

[terraform]

Make forwarding rule service_label and service_name GA, add to test

[terraform-beta]

Make forwarding rule service_label and service_name GA, add to test

[ansible]

Make forwarding rule service_label and service_name GA

[inspec]

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 3e0c48eb718833f5412e2d87bcc8ae93abcc88fa.

Pull request statuses

No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#564
depends: GoogleCloudPlatform/terraform-google-conversion#36
depends: hashicorp/terraform-provider-google#3333
depends: modular-magician/ansible#221

@emilymye emilymye force-pushed the forwarding_rule_ga_ilb branch from 3e0c48e to 2dccdcb Compare March 27, 2019 23:21
@emilymye
Copy link
Contributor Author

Going to remove inline yaml (forwarding_rules_properties.yaml) from global forwarding rule in a separate PR so I don't accidently overwrite some difference in behavior.

@emilymye emilymye force-pushed the forwarding_rule_ga_ilb branch from d5ab794 to 05c748c Compare March 27, 2019 23:36
@emilymye emilymye requested review from rileykarson and chrisst March 27, 2019 23:39
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d5ab794.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 05c748c.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

emilymye and others added 4 commits March 28, 2019 17:15
@modular-magician modular-magician merged commit 94cd136 into GoogleCloudPlatform:master Mar 28, 2019
@modular-magician modular-magician mentioned this pull request Mar 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

@chrisst chrisst Awaiting requested review from chrisst

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emilymye @modular-magician @rileykarson @googlebot