Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform]: Make zone required in google_composer_environment.node_config #1327

Merged

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Jan 30, 2019

Fixes hashicorp/terraform-provider-google#2966

Our tests already define the field, and have an example where the block isn't defined.

Waiting on CI test run to assign. CI is done!


[all]

[terraform]

Make zone required in google_composer_environment.node_config

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#396
depends: hashicorp/terraform-provider-google#2967

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 420b8b7) have been included in your existing downstream PRs.

@modular-magician modular-magician merged commit ef2dcff into GoogleCloudPlatform:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants