Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerate provider-compute-gen.go file #132

Merged
merged 5 commits into from
Apr 30, 2018
Merged

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Apr 28, 2018

This change allows to introduce new resources to Terraform in one MM commit (allows to also run the terraform acceptance tests against that PR).


[all]

[terraform]

Autogenerate provider-compute-gen.go file

[puppet]

[puppet-dns]

[puppet-sql]

[puppet-compute]

[chef]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@rosbo
Copy link
Contributor Author

rosbo commented Apr 30, 2018

@ndmckinley, you are correct, the merge commit didn't, this PR should have generated a change in the Terraform repository.

@nat-henderson
Copy link
Contributor

Typo - fixed in #133.

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, I missed that you also wanted a review. LGTM.

@rosbo
Copy link
Contributor Author

rosbo commented Apr 30, 2018

Is there an easy way for me to kickoff a new pipeline run to generate the code for the downstream repo?

@rosbo rosbo force-pushed the resource-map-gen branch from 03651fc to 9106bc8 Compare April 30, 2018 18:37
@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#1402

nat-henderson and others added 3 commits April 30, 2018 12:48
@modular-magician modular-magician merged commit 3442a72 into master Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants