Update docs on running single tests #12801
Open
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
The examples refer to running a single test, but the `-run` command example could potentially run lots of tests unexpectedly. Use a `-run=` example with the correct syntax for passing a literal dollar sign to the regex -- while the docs link to the golang docs, because of shell quoting and because of it getting passed via make, it seems to be necessary to use double dollar signs. Fixes hashicorp/terraform-provider-google#19934
wyardley
force-pushed
the
wyardley/issues/19934
branch
from
0945606 to
257596c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples refer to running a single test, but the
-runcommand in the example could potentially run lots of tests unexpectedly.Use a
-run=example with the correct syntax for passing a literal dollar sign to the regex -- while the docs link to the golang docs, because of shell quoting and because of it getting passed via make, it seems to be necessary to use double dollar signs.I don't 100% know this is the right solution, but I haven't gotten a direct answer or an example of a better way to do it.
Open to suggestions both as to a better fix
I debated anchoring on the front side as well (
-run=^TestFoo_bar$$), but seems less necessary. But it is very easy to accidentally kick off a whole bunch of expensive and slow tests if you match too broadly, including if you use a bad regex, forget the dash beforerun, or do any number of other things.Fixes hashicorp/terraform-provider-google#19934
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.