Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EphemeralWriteOnly: add secretVersionWo #12800

Draft
wants to merge 1 commit into
base: FEATURE-BRANCH-ephemeral-write-only
Choose a base branch
from

Conversation

BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Jan 18, 2025

Need to look into why we get a diff in the request before moving it out of draft:

secret_data:

2025-01-17T17:59:12.091-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: ---[ REQUEST ]---------------------------------------
2025-01-17T17:59:12.091-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: POST /v1/projects/hc-terraform-testing/secrets/secret-version:addVersion?alt=json HTTP/1.1
2025-01-17T17:59:12.091-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: Host: secretmanager.googleapis.com
2025-01-17T17:59:12.091-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: User-Agent: Terraform/1.11.0-beta1 (+https://www.terraform.io) Terraform-Plugin-SDK/2.35.0 terraform-provider-google/dev6
2025-01-17T17:59:12.091-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: Content-Length: 40
2025-01-17T17:59:12.091-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: Content-Type: application/json
2025-01-17T17:59:12.091-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: Accept-Encoding: gzip
2025-01-17T17:59:12.091-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64
2025-01-17T17:59:12.091-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: {
2025-01-17T17:59:12.091-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64:  "payload": {
2025-01-17T17:59:12.091-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64:   "data": "c2VjcmV0LWRhdGE="
2025-01-17T17:59:12.091-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64:  }
2025-01-17T17:59:12.091-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: }
2025-01-17T17:59:12.091-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64
2025-01-17T17:59:12.091-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: -----------------------------------------------------

secret_data_wo:

2025-01-17T17:58:16.611-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: ---[ REQUEST ]---------------------------------------
2025-01-17T17:58:16.611-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: POST /v1/projects/hc-terraform-testing/secrets/secret-version:addVersion?alt=json HTTP/1.1
2025-01-17T17:58:16.611-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: Host: secretmanager.googleapis.com
2025-01-17T17:58:16.611-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: User-Agent: Terraform/1.11.0-beta1 (+https://www.terraform.io) Terraform-Plugin-SDK/2.35.0 terraform-provider-google/dev6
2025-01-17T17:58:16.611-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: Content-Length: 3
2025-01-17T17:58:16.611-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: Content-Type: application/json
2025-01-17T17:58:16.611-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: Accept-Encoding: gzip
2025-01-17T17:58:16.611-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64
2025-01-17T17:58:16.611-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: {}
2025-01-17T17:58:16.611-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64
2025-01-17T17:58:16.611-0800 [DEBUG] provider.terraform-provider-google_9.9.9_darwin_arm64: -----------------------------------------------------

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 57 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 2 files changed, 57 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 18 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • secretmanager

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants