-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support apigee environment properties update #12794
base: main
Are you sure you want to change the base?
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 54 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
@@ -23,9 +23,6 @@ docs: | |||
base_url: 'environments' | |||
self_link: '{{org_id}}/environments/{{name}}' | |||
create_url: '{{org_id}}/environments' | |||
update_url: '{{org_id}}/environments/{{name}}' | |||
update_verb: 'PATCH' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the update mask is no longer used I thought it made sense to use default values when possible, that is the reason for the changes on ln 26 & 27. Update mask is no longer being used as it does not support updating the properties
field.
Update google_apigee_environment update operation's http verb from
PATCH
(modifyEnvironment) toPUT
(update).Note from the update operation's API doc:
Note: Both PUT and POST methods are supported for updating an existing environment.
Partially Fixes: hashicorp/terraform-provider-google#20931
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.