add support for internet IP health checking to routing policies #12684

hkundag · 2025-01-03T19:36:57Z

Adds support for internet IP address health checking to routing policies in public managed zones.

b/384932633 b/352032481

Release Note Template for Downstream PRs (will be copied)

dns: added `routing_policy.health_check` and `health_checked_targets.external_endpoints` to `google_dns_record_set`

github-actions · 2025-01-03T19:37:37Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

rosmo · 2025-01-03T19:39:40Z

@hkundag Looks like we did the same work, one hour apart. #12682

modular-magician · 2025-01-03T19:47:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 128 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 128 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dns_record_set (37 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dns_record_set" "primary" {
  routing_policy {
    geo {
      health_checked_targets {
        external_endpoints = # value needed
      }
    }
    primary_backup {
      backup_geo {
        health_checked_targets {
          external_endpoints = # value needed
        }
      }
    }
    wrr {
      health_checked_targets {
        external_endpoints = # value needed
      }
    }
  }
}

hkundag · 2025-01-03T19:48:24Z

Oh thanks for pointing that out (and for working on this)! I don't mind taking ownership here since I'm on the service team.

modular-magician · 2025-01-03T19:51:19Z

Tests analytics

Total tests: 47
Passed tests: 45
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDNSRecordSet_routingPolicy

Get to know how VCR tests work

modular-magician · 2025-01-03T19:57:17Z

🔴 Tests failed during RECORDING mode:
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-03T20:36:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 204 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 3 files changed, 197 insertions(+), 24 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dns_record_set (37 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dns_record_set" "primary" {
  routing_policy {
    geo {
      health_checked_targets {
        external_endpoints = # value needed
      }
    }
    primary_backup {
      backup_geo {
        health_checked_targets {
          external_endpoints = # value needed
        }
      }
    }
    wrr {
      health_checked_targets {
        external_endpoints = # value needed
      }
    }
  }
}

modular-magician · 2025-01-03T20:36:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 197 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 3 files changed, 197 insertions(+), 24 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dns_record_set (37 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dns_record_set" "primary" {
  routing_policy {
    geo {
      health_checked_targets {
        external_endpoints = # value needed
      }
    }
    primary_backup {
      backup_geo {
        health_checked_targets {
          external_endpoints = # value needed
        }
      }
    }
    wrr {
      health_checked_targets {
        external_endpoints = # value needed
      }
    }
  }
}

modular-magician · 2025-01-03T20:40:23Z

Tests analytics

Total tests: 47
Passed tests: 45
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDNSRecordSet_routingPolicy

Get to know how VCR tests work

modular-magician · 2025-01-03T20:40:48Z

Tests analytics

Total tests: 47
Passed tests: 45
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDNSRecordSet_routingPolicy

Get to know how VCR tests work

modular-magician · 2025-01-03T20:43:26Z

🔴 Tests failed during RECORDING mode:
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-03T20:43:50Z

🔴 Tests failed during RECORDING mode:
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-03T20:49:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 336 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 3 files changed, 336 insertions(+), 24 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dns_record_set (39 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dns_record_set" "primary" {
  routing_policy {
    primary_backup {
      backup_geo {
        health_checked_targets {
          external_endpoints = # value needed
        }
      }
    }
  }
}

modular-magician · 2025-01-03T20:53:30Z

Tests analytics

Total tests: 48
Passed tests: 45
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages

dns

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDNSRecordSet_routingPolicy

TestAccDNSRecordSet_routingPolicyInternetHealthCheck

Get to know how VCR tests work

modular-magician · 2025-01-03T20:56:22Z

🔴 Tests failed during RECORDING mode:
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicyInternetHealthCheck [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-03T20:56:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 336 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 3 files changed, 336 insertions(+), 24 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dns_record_set (39 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dns_record_set" "primary" {
  routing_policy {
    primary_backup {
      backup_geo {
        health_checked_targets {
          external_endpoints = # value needed
        }
      }
    }
  }
}

modular-magician · 2025-01-03T21:00:43Z

Tests analytics

Total tests: 48
Passed tests: 45
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages

dns

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDNSRecordSet_routingPolicy

TestAccDNSRecordSet_routingPolicyInternetHealthCheck

Get to know how VCR tests work

modular-magician · 2025-01-03T21:03:35Z

🔴 Tests failed during RECORDING mode:
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicyInternetHealthCheck [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-03T22:00:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 333 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 3 files changed, 333 insertions(+), 24 deletions(-))

modular-magician · 2025-01-03T22:40:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 327 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 3 files changed, 327 insertions(+), 19 deletions(-))

modular-magician · 2025-01-03T22:44:43Z

Tests analytics

Total tests: 48
Passed tests: 46
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDNSRecordSet_routingPolicyInternetHealthCheck

Get to know how VCR tests work

modular-magician · 2025-01-03T22:45:14Z

🔴 Tests failed during RECORDING mode:
TestAccDNSRecordSet_routingPolicyInternetHealthCheck [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-03T23:05:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 335 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 3 files changed, 335 insertions(+), 19 deletions(-))

modular-magician · 2025-01-03T23:09:38Z

Tests analytics

Total tests: 48
Passed tests: 46
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDNSRecordSet_routingPolicyInternetHealthCheck

Get to know how VCR tests work

modular-magician · 2025-01-03T23:10:25Z

🔴 Tests failed during RECORDING mode:
TestAccDNSRecordSet_routingPolicyInternetHealthCheck [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-03T23:36:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 335 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 3 files changed, 335 insertions(+), 19 deletions(-))

modular-magician · 2025-01-03T23:40:11Z

Tests analytics

Total tests: 48
Passed tests: 46
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDNSRecordSet_routingPolicyInternetHealthCheck

Get to know how VCR tests work

modular-magician · 2025-01-03T23:40:58Z

🔴 Tests failed during RECORDING mode:
TestAccDNSRecordSet_routingPolicyInternetHealthCheck [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-03T23:57:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 337 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 3 files changed, 337 insertions(+), 19 deletions(-))

modular-magician · 2025-01-04T00:01:13Z

Tests analytics

Total tests: 48
Passed tests: 46
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDNSRecordSet_routingPolicyInternetHealthCheck

Get to know how VCR tests work

modular-magician · 2025-01-04T00:02:12Z

🔴 Tests failed during RECORDING mode:
TestAccDNSRecordSet_routingPolicyInternetHealthCheck [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-04T00:29:24Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 361 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 3 files changed, 361 insertions(+), 19 deletions(-))

modular-magician · 2025-01-04T00:33:19Z

Tests analytics

Total tests: 48
Passed tests: 46
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDNSRecordSet_routingPolicyInternetHealthCheck

Get to know how VCR tests work

modular-magician · 2025-01-04T00:33:34Z

🔴 Tests failed during RECORDING mode:
TestAccDNSRecordSet_routingPolicyInternetHealthCheck [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-04T00:48:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 364 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 3 files changed, 364 insertions(+), 19 deletions(-))

modular-magician · 2025-01-04T00:51:56Z

Tests analytics

Total tests: 48
Passed tests: 46
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDNSRecordSet_routingPolicyInternetHealthCheck

Get to know how VCR tests work

modular-magician · 2025-01-04T00:54:55Z

🔴 Tests failed during RECORDING mode:
TestAccDNSRecordSet_routingPolicyInternetHealthCheck [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-04T01:10:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 364 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 3 files changed, 364 insertions(+), 19 deletions(-))

modular-magician · 2025-01-04T01:14:33Z

Tests analytics

Total tests: 48
Passed tests: 46
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDNSRecordSet_routingPolicyInternetHealthCheck

Get to know how VCR tests work

modular-magician · 2025-01-04T01:19:34Z

🔴 Tests failed during RECORDING mode:
TestAccDNSRecordSet_routingPolicyInternetHealthCheck [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

ScottSuarez

Hi @hkundag, I see this PR is in draft. Feel free to ping me if you have any questions.

github-actions bot requested a review from ScottSuarez January 3, 2025 19:37

modular-magician added the service/cloud-dns label Jan 3, 2025

hkundag marked this pull request as draft January 3, 2025 19:49

hkundag force-pushed the phase3 branch from bfcfff4 to fe665d4 Compare January 3, 2025 20:24

add support for internet IP health checking to routing policies

4efbd54

hkundag force-pushed the phase3 branch from fe665d4 to 4efbd54 Compare January 3, 2025 20:25

add tests for internet health checked geo/wrr policies

991fbc7

give test resources useful names

4280b32

hkundag added 2 commits January 3, 2025 21:45

remove google-beta from example health check

7c0ee1f

fix internet health check backup geo config

f1ecf5f

hkundag mentioned this pull request Jan 3, 2025

give meaningful names to rrsets in routing policy tests #12685

Draft

store health check and external endpoints in state during read

489cae9

rerun checks

d50970b

make ihc tests use zones with different names

001bc60

wait 2m before deleting health check

57bbc4b

add time to external providers

cbe030a

sleep for 4m instead of 2

e3bad31

ScottSuarez reviewed Jan 6, 2025

View reviewed changes

prevent resource overlap between ihc test cases

d4624c2

hkundag closed this Jan 9, 2025

add support for internet IP health checking to routing policies #12684

add support for internet IP health checking to routing policies #12684

Conversation

hkundag commented Jan 3, 2025

github-actions bot commented Jan 3, 2025

rosmo commented Jan 3, 2025 • edited Loading

modular-magician commented Jan 3, 2025

Diff report

Missing test report

hkundag commented Jan 3, 2025

modular-magician commented Jan 3, 2025

Tests analytics

Action taken

modular-magician commented Jan 3, 2025

modular-magician commented Jan 3, 2025

Diff report

Missing test report

modular-magician commented Jan 3, 2025

Diff report

Missing test report

modular-magician commented Jan 3, 2025

Tests analytics

Action taken

modular-magician commented Jan 3, 2025

Tests analytics

Action taken

modular-magician commented Jan 3, 2025

modular-magician commented Jan 3, 2025

modular-magician commented Jan 3, 2025

Diff report

Missing test report

modular-magician commented Jan 3, 2025

Tests analytics

Action taken

modular-magician commented Jan 3, 2025

modular-magician commented Jan 3, 2025

Diff report

Missing test report

modular-magician commented Jan 3, 2025

Tests analytics

Action taken

modular-magician commented Jan 3, 2025

modular-magician commented Jan 3, 2025

Diff report

modular-magician commented Jan 3, 2025

Diff report

modular-magician commented Jan 3, 2025

Tests analytics

Action taken

modular-magician commented Jan 3, 2025

modular-magician commented Jan 3, 2025

Diff report

modular-magician commented Jan 3, 2025

Tests analytics

Action taken

modular-magician commented Jan 3, 2025

modular-magician commented Jan 3, 2025

Diff report

modular-magician commented Jan 3, 2025

Tests analytics

Action taken

modular-magician commented Jan 3, 2025

modular-magician commented Jan 3, 2025

Diff report

modular-magician commented Jan 4, 2025

Tests analytics

Action taken

modular-magician commented Jan 4, 2025

modular-magician commented Jan 4, 2025

Diff report

modular-magician commented Jan 4, 2025

Tests analytics

Action taken

modular-magician commented Jan 4, 2025

modular-magician commented Jan 4, 2025

Diff report

modular-magician commented Jan 4, 2025

Tests analytics

Action taken

modular-magician commented Jan 4, 2025

rosmo commented Jan 3, 2025 •

edited

Loading