Fix usage of log.Fatalf() in main.go

[lychgoogle]

It's a simple fix that'll resolve following lint error on building provider

$ make build
==> Checking that code complies with gofmt requirements...
go vet
# github.com/hashicorp/terraform-provider-google-beta
# [github.com/hashicorp/terraform-provider-google-beta]
./main.go:36:14: non-constant format string in call to log.Fatalf
make: *** [GNUmakefile:29: vet] Error 1

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 4382
Passed tests: 3948
Skipped tests: 429
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccEphemeralServiceAccountKey_basic
• TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccStorageTransferReplicationJob_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[lychgoogle]

I don't think any failure in #12655 (comment) is related to my change.

[github-actions]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[uberferg]

Hi, I'm not a reviewer, just another Googler trying to make some Terraform changes. I noticed this issue extends beyond just main.go, and is also present in several of the services/tests, for example here in the instance guest attributes template.

A full list of the files with this issue can be seen by following the instructions here to make all the tests and seeing the various compilation errors.

I'm just wondering whether I should make another pull request to fix this in the other places, or if the maintainers of the repo would prefer this be handled here in a single PR for all the format string errors?

[c2thorn]

Hi, I'm not a reviewer, just another Googler trying to make some Terraform changes. I noticed this issue extends beyond just main.go, and is also present in several of the services/tests, for example here in the instance guest attributes template.

A full list of the files with this issue can be seen by following the instructions here to make all the tests and seeing the various compilation errors.

I'm just wondering whether I should make another pull request to fix this in the other places, or if the maintainers of the repo would prefer this be handled here in a single PR for all the format string errors?

A separate pull request should be fine