Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post-create/post-update sleep to KMS AutokeyConfig #12649

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

tdbhacks
Copy link
Member

@tdbhacks tdbhacks commented Dec 24, 2024

Attempts to fix hashicorp/terraform-provider-google#18935

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

kms: added 5 second sleep post-create / post-update to `google_kms_autokey_config`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 1 file changed, 9 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 41
Passed tests: 35
Skipped tests: 6
Affected tests: 0

Click here to see the affected service packages
  • kms

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 9 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 41
Passed tests: 35
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages
  • kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@tdbhacks tdbhacks marked this pull request as ready for review December 24, 2024 14:44
@github-actions github-actions bot requested a review from ScottSuarez December 24, 2024 14:44
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@tdbhacks
Copy link
Member Author

cc: @melinath, who is aware of this change and proposed a potential solution to the test flakiness. VCR seems happy? 🤷

Copy link

@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @ScottSuarez This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample
3 participants