Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource types #12605

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix resource types #12605

merged 1 commit into from
Dec 18, 2024

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Dec 18, 2024

These are the remaining fixes we found after comparing compliance against the previous mapping. While the previous values technically correlate with valid resource names, they are not the canonical name that is used internally.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@roaks3 roaks3 requested review from a team and rileykarson and removed request for a team December 18, 2024 21:04
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))

@roaks3 roaks3 merged commit 37e4abb into main Dec 18, 2024
12 checks passed
@roaks3 roaks3 deleted the resource-type-fixes-20241218 branch December 18, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants